Let's implement this change record: https://www.drupal.org/node/2973262

CommentFileSizeAuthor
#2 group-3040578-2.patch4.67 KBkristiaanvandeneynde

Comments

kristiaanvandeneynde created an issue. See original summary.

kristiaanvandeneynde’s picture

kristiaanvandeneynde
Primary language Dutch
Location Antwerp, Belgium
commented
Status: Active » Needs review
StatusFileSize
new group-3040578-2.patch4.67 KB

Status: Needs review » Needs work

The last submitted patch, 2: group-3040578-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

kristiaanvandeneynde’s picture

kristiaanvandeneynde
Primary language Dutch
Location Antwerp, Belgium
commented
Status: Needs work » Needs review

This failed because of a new test requirement by core (see https://www.drupal.org/node/3036689). Fixed in child issue, retesting.

kristiaanvandeneynde’s picture

kristiaanvandeneynde
Primary language Dutch
Location Antwerp, Belgium
commented
Status: Needs review » Fixed
penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented

This makes the Group module incompatible with 8.5.x. I'm sure you know about that, but just in case someone lands here as I did.
Related: #3040731: Skip Group integration tests if Drupal Core is 8.5.x

kristiaanvandeneynde’s picture

kristiaanvandeneynde
Primary language Dutch
Location Antwerp, Belgium
commented

Okay, will bump version up to 8.6.x then (because we actually want to use this cache elsewhere too). Thanks for catching this!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.