Problem/Motivation

Originally reported by Mike Dodd

as reported at #3037791-14: Convert tests to PHPUnit, core introduced Drupal\Component\Utility\EmailValidator in 8.7.x and causing fatal error to the sites using stable core version.

Proposed resolution

Add a conditional check for now to support both as the latest version of Egulias\EmailValidator\EmailValidator breaks API which is why we got own instance in core. Check #2755401: Upgrade EmailValidator to 2.x for more details.

Remaining tasks

CommentFileSizeAuthor
#5 3038799-empty-5.patch0 bytesvijaycs85
#4 3038799-diff-2-4.txt1.63 KBvijaycs85
#4 3038799-4.patch3.14 KBvijaycs85
#2 3038799-2.patch1.94 KBvijaycs85

Comments

vijaycs85 created an issue. See original summary.

vijaycs85’s picture

vijaycs85
Location London, UK
commented
Status: Active » Needs review
StatusFileSize
new 3038799-2.patch1.94 KB

Status: Needs review » Needs work

The last submitted patch, 2: 3038799-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

vijaycs85’s picture

vijaycs85
Location London, UK
commented
Status: Needs work » Needs review
StatusFileSize
new 3038799-4.patch3.14 KB
new 3038799-diff-2-4.txt1.63 KB

Updating typehint.

vijaycs85’s picture

vijaycs85
Location London, UK
commented
StatusFileSize
new 3038799-empty-5.patch0 bytes

Here is an empty file to prove that the current HEAD fails with the 8.6.x core.

  • vijaycs85 committed 36b9786 on 8.x-1.x 
    Issue #3038799 by vijaycs85: BC for Drupal\Component\Utility\...

vijaycs85 credited Mike Dodd.

vijaycs85’s picture

vijaycs85
Location London, UK
commented
Status: Needs review » Fixed

nevermind #5 checked directly at 8.x-1.x HEAD and failing as expected. See https://www.drupal.org/pift-ci-job/1223472 for more details

Mike Dodd’s picture

Mike Dodd commented

Thank, this is working fine now :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.