Problem/Motivation
The four questions have been combined into a single field (see: #3015379: Use a single field for all four questions), but all four questions are currently hard-coded in the FAPI to be required regardless of the field's settings.
Proposed resolution
Respect the field's required setting in the FAPI.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | before.png | 48.77 KB | ethomas08 |
| #6 | after.png | 52.89 KB | ethomas08 |
| #4 | interdiff_3_4.txt | 3.02 KB | alexdmccabe |
| #4 | gender-make_required_checkbox_work-3034475-4-7.patch | 5.64 KB | alexdmccabe |
| #3 | gender-make_required_checkbox_work-3034475-3-7.patch | 3.87 KB | alexdmccabe |
Comments
Comment #2
alexdmccabeComment #3
alexdmccabeI think this is functionally complete, but it still needs tests. Just uploading the work I've done so far.
Comment #4
alexdmccabeComment #5
ethomas08 commentedComment #6
ethomas08 commentedThe patch applied cleanly. I am attaching before and after screenshots from my manual testing.
After applying the patch, the fields that are not required default to the empty -Select- option.
Each form element now has:
#required' => $required
instead of:
#required' => TRUE
Looks good -- works as intended.
Comment #8
alexdmccabeComment #9
alexdmccabeThanks for reviewing, @ethomas08!