From #3027394: Add View Mode Dropdown for Rendering the link.

+++ b/src/Plugin/Field/FieldFormatter/EntityQuicklookFormatter.php
@@ -96,6 +112,21 @@ class EntityQuicklookFormatter extends EntityReferenceFormatterBase implements C
+      '#required' => TRUE,

Should we make this setting required? It seems somewhat confusing how in the description this setting is being described as optional, and yet the setting is required.

I also noticed that when I check the checkbox to use the custom link text and I provide a string to be used in the link text setting, my custom string is not being used.
Similarly for the custom modal title setting, when I do not check the checkbox to use the custom modal title and I provide a string to be used in the modal title, my custom string is being used but since I didn't check the checkbox shouldn't the entity label be the modal title?

CommentFileSizeAuthor
#3 3030600-link-modal-titles-03.patch1.88 KBgmem

Comments

gmem created an issue. See original summary.

gmem’s picture

gmem commented
Title: Modal and Link Tsitle » Modal and Link Titles
gmem’s picture

gmem commented
StatusFileSize
new 3030600-link-modal-titles-03.patch1.88 KB
gmem’s picture

gmem commented
Status: Active » Needs review
joshmiller’s picture

joshmiller
he/him
Primary language English
Location Indianapolis, Indiana, USA
commented
Status: Needs review » Reviewed & tested by the community 
+++ b/src/Plugin/Field/FieldFormatter/EntityQuicklookFormatter.php
@@ -29,7 +29,7 @@ use Drupal\Core\Language\LanguageInterface;
+class   EntityQuicklookFormatter extends EntityReferenceFormatterBase implements ContainerFactoryPluginInterface {

Extra space nitpick, if you want to keep it clean, make sure to keep the extra space out of the commit.

Otherwise, looks good.

  • gmem committed 8017328 on 8.x-1.x 
    Issue #3030600 by gmem, joshmiller: Modal and Link Titles
gmem’s picture

gmem commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.