Problem/Motivation

simpletest_generate_file() is unused in core.

Proposed resolution

Deprecate simpletest_generate_file() formally.

Replaced by Drupal\Tests\TestFileCreationTrait.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#8 3028708_8.patch1.9 KBMile23
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Mile23 created an issue. See original summary.

Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 as a volunteer commented
Issue tags: +Needs change record
Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 as a volunteer commented
Issue summary: View changes
Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 as a volunteer commented
Issue summary: View changes
Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 as a volunteer commented
Related issues: +#2738567: Add test trait for drupalGetTestFiles and drupalCompareFile

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 as a volunteer commented

CR for this issue and #2738567: Add test trait for drupalGetTestFiles and drupalCompareFile : https://www.drupal.org/node/3077768

Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 as a volunteer commented
Status: Active » Needs review
Issue tags: -Needs change record
FileSize
3028708_8.patch1.9 KB
Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 as a volunteer commented
Related issues: +#3057420: [meta] How to deprecate Simpletest with minimal disruption
kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
CreditAttribution: kim.pepper at PreviousNext commented
Status: Needs review » Reviewed & tested by the community

LGTM 👍

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Status: Reviewed & tested by the community » Fixed 
+++ b/core/modules/simpletest/tests/src/Kernel/SimpletestDeprecationTest.php
@@ -82,4 +82,14 @@ public function testDeprecatedPhpUnitFunctions() {
+    $this->assertTrue(unlink($public_file));

Strictly this is unnecessary because we remove all files as far as I know. But can't hurt so /shrug.

Committed a99b54f and pushed to 8.8.x. Thanks!

  • alexpott committed a99b54f on 8.8.x 
    Issue #3028708 by Mile23: Deprecate simpletest_generate_file()

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

quietone’s picture

quietone CreditAttribution: quietone at PreviousNext commented

publish the change record