Instead of reading out permissions from various roles (and thus potentially introducing a security risk), we should prepare Group for a centralized permission system. Step two would be to introduce a service that calculates someone's permissions and returns them as CalculatedGroupPermissions objects (introduced here: #3028337: Introduce a value object to store calculated permissions with cacheable metadata).

CommentFileSizeAuthor
#3 group-3028340-3.patch29.22 KBkristiaanvandeneynde
#2 group-3028340-2.patch28.42 KBkristiaanvandeneynde

Comments

kristiaanvandeneynde created an issue. See original summary.

kristiaanvandeneynde’s picture

kristiaanvandeneynde
Primary language Dutch
Location Antwerp, Belgium
commented
Title: Create a central service that calculates someone's group permissions » [PP-1] Create a central service that calculates someone's group permissions
Status: Active » Needs work
StatusFileSize
new group-3028340-2.patch28.42 KB

Depends on the code from the linked issue, so not running tests yet.

kristiaanvandeneynde’s picture

kristiaanvandeneynde
Primary language Dutch
Location Antwerp, Belgium
commented
Title: [PP-1] Create a central service that calculates someone's group permissions » Create a central service that calculates someone's group permissions
Status: Needs work » Needs review
StatusFileSize
new group-3028340-3.patch29.22 KB

Other issue got committed, here we go. (Forgot to add service declaration, doing so now).

kristiaanvandeneynde’s picture

kristiaanvandeneynde
Primary language Dutch
Location Antwerp, Belgium
commented
Status: Needs review » Fixed

In it goes.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.