* When a system uses a non StUF-BG 0310 soap method it want to alter the soap method and wsdl
* Provide alters to be able to create a module overriding

CommentFileSizeAuthor
#3 interdiff-2-3.txt6.39 KBpaulvandenburg
#3 provide-wsdl-and-method-alters-3025798-3.patch5.77 KBpaulvandenburg
#2 provide-wsdl-and-method-alters-3025798.patch6.96 KBralphvdhoudt

Comments

ralphvdhoudt created an issue. See original summary.

ralphvdhoudt’s picture

ralphvdhoudt commented
Status: Active » Needs review
StatusFileSize
new provide-wsdl-and-method-alters-3025798.patch6.96 KB
paulvandenburg’s picture

paulvandenburg commented
StatusFileSize
new provide-wsdl-and-method-alters-3025798-3.patch5.77 KB
new interdiff-2-3.txt6.39 KB

Functionally it looks good. However I have 2 issues:
In the api.php file the function documentation should describe what de hook does and/or what you can use it for.

Having separate hooks for each api call type as well as for wsdl + method seems wasteful.
I doubt there will ever be a case where only either the wsdl or method is changed instead of both.
I also suggest grouping all the new hooks together to just 1 api call alter hook and passing the api call type as a parameter.

I've made both changes in the attached path.

tvoesenek’s picture

tvoesenek commented
Status: Needs review » Reviewed & tested by the community

I agree with Paul on this, patch #3 looks good.

  • paulvandenburg committed b6b33ce on 7.x-1.x 
    Issue #3025798 by paulvandenburg, ralphvdhoudt: Allow modules to alter...
paulvandenburg’s picture

paulvandenburg commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.