[D8] User Switch

Thank you for your contribution!
I am adding the PAReview checklist link. If you haven't done it yet, please check the reported issues, and fix the code as indicated. Don't pay attention to the false positives the checklist could contain.

Next, the reviewers will check the project code, and report here what needs to be changed.

Review the pareview you have a some errors.

Review of the 8.x-1.x branch (commit 877e207):

• The userswitch.module does not implement hook_help(). See https://www.drupal.org/docs/develop/documenting-your-project/module-docu... .
• DrupalPractice has found some issues with your code, but could be false positives.
  

  
  FILE: ...e1101/web/vendor/drupal/pareviewsh/pareview_temp/userswitch.info.yml
  --------------------------------------------------------------------------
  FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
  --------------------------------------------------------------------------
   6 | WARNING | All dependencies must be prefixed with the project name,
     |         | for example "drupal:"
  --------------------------------------------------------------------------
  
  
  FILE: ...pal/pareviewsh/pareview_temp/src/Controller/UserSwitchController.php
  --------------------------------------------------------------------------
  FOUND 0 ERRORS AND 5 WARNINGS AFFECTING 4 LINES
  --------------------------------------------------------------------------
    45 | WARNING | \Drupal calls should be avoided in classes, use
       |         | dependency injection instead
    46 | WARNING | \Drupal calls should be avoided in classes, use
       |         | dependency injection instead
    62 | WARNING | \Drupal calls should be avoided in classes, use
       |         | dependency injection instead
    62 | WARNING | t() calls should be avoided in classes, use dependency
       |         | injection and $this->t() instead
   129 | WARNING | \Drupal calls should be avoided in classes, use
       |         | dependency injection instead
  --------------------------------------------------------------------------
  
  
  FILE: ...te1101/web/vendor/drupal/pareviewsh/pareview_temp/src/UserSwitch.php
  --------------------------------------------------------------------------
  FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
  --------------------------------------------------------------------------
    85 | WARNING | User::load calls should be avoided in classes, use
       |         | dependency injection instead
    87 | WARNING | \Drupal calls should be avoided in classes, use
       |         | dependency injection instead
   102 | WARNING | User::load calls should be avoided in classes, use
       |         | dependency injection instead
   111 | WARNING | \Drupal calls should be avoided in classes, use
       |         | dependency injection instead
  --------------------------------------------------------------------------
  
  Time: 487ms; Memory: 4Mb
  

Update this issue to Need Review

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.