Add option to schedule a transition for a specific translation

Really nice work. Thanks, for creating the issue and the patch. Let's add some tests.

1. +++ b/src/Form/Entity/ScheduledTransitionAddForm.php
   @@ -322,14 +337,23 @@ class ScheduledTransitionAddForm extends ContentEntityForm {
   +      $revision = $entityStorage->loadRevision($revisionId);
   +      if ($revision instanceof TranslatableInterface) {
   +        $revision = $revision->getTranslation($this->languageManager->getCurrentLanguage()->getId());
   +      }
   +      return $revision;
   

   Let's add a comment here?

2. +++ b/src/Form/Entity/ScheduledTransitionAddForm.php
   @@ -322,14 +337,23 @@ class ScheduledTransitionAddForm extends ContentEntityForm {
   +    $entityRevisions = array_filter($entityRevisions, function (EntityInterface $revision) {
   +      return $revision instanceof TranslatableRevisionableInterface ? $revision->isRevisionTranslationAffected() : TRUE;
   +    });
   

   Can we please add a comment here, as well?

Thanks, for addressing the feedback. We'll create a meta for tests and address this there.

Patch looks reasonable.

Took a while for me to get re-acquainted with how translation works (procrastination). This is definitely going to need tests as I can easily see myself or others breaking changes introduced by this issue.

Ive got a feeling showing the current language for the list page and form will bite us in the future. Going to overlook it in the meantime.

Some feedback

• add return types for new lang method in transition entity.
• all/similar the same tests for NON-translatable entity. Make sure features work the same if entity is not translatable.
• Langcode field should be required. Double check usage of new lang method should account for NULL values.
• Views field plugin needs update (as used by default view).

Suggested test scenarios

• test for runner, must transition correct id/rev/t9n
• test for count in tab, count must not show id/rev/t9n relevant to currentUser
• test for only showing language in list, must transition correct id/rev/t9n
• test for only showing language in list in form, must transition correct id/rev/t9n
• test for lang method on transition entity
• others as needed

This issue is the remaining blocker for 1.0

• A slew of tests.
• Updated coding to project standard.
• Changed method to account for possible NULL value.

Nice work on tests 👏👏👏👏👏👏

+++ b/tests/src/Kernel/ScheduledTransitionTest.php
@@ -437,6 +444,63 @@ class ScheduledTransitionTest extends KernelTestBase {
+    $entity->save();

I didn't know that saving the entity will save the translations as well.

Fixes bad test, problem with site in subdirectory on drupalci

I didn't know that saving the entity will save the translations as well.

PHP magic; objects always references. Good stuff.

missed one 🤞

Committed with minor amendments.

Added an empty authorship commit.