CommentFileSizeAuthor
#4 fixing_coder_3019702_2.patch1.25 KBharshil.maradiya
#2 fixing_coder_3019702.patch1.16 KBharshil.maradiya

Comments

harshil.maradiya created an issue. See original summary.

harshil.maradiya’s picture

harshil.maradiya commented
Status: Active » Needs review
StatusFileSize
new fixing_coder_3019702.patch1.16 KB
legolasbo’s picture

legolasbo
he/him
Primary language Dutch
Location Middelburg
commented
Status: Needs review » Needs work

I've reviewed your patch in relation to the PHPCS warnings generated by the test runner. It seems like you haven't caught all warnings yet. Please make sure you fix all PHPCS warnings.

harshil.maradiya’s picture

harshil.maradiya commented
StatusFileSize
new fixing_coder_3019702_2.patch1.25 KB
harshil.maradiya’s picture

harshil.maradiya commented
Status: Needs work » Needs review

I have updated code review comments

The last submitted patch, 2: fixing_coder_3019702.patch, failed testing. View results

Status: Needs review » Needs work

The last submitted patch, 4: fixing_coder_3019702_2.patch, failed testing. View results

harshil.maradiya’s picture

harshil.maradiya commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 4: fixing_coder_3019702_2.patch, failed testing. View results

  • legolasbo committed cbc8f50 on 8.x-1.x 
    Issue #3019702 by legolasbo: Fixing Coder related warnings
legolasbo’s picture

legolasbo
he/him
Primary language Dutch
Location Middelburg
commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.