Currently module is using SKU: Dynamic Maps which is billable. https://developers.google.com/maps/billing/understanding-cost-of-use#dyn...
We need to add SKU: Embed to make sure the user has option to select between paid and free modes.
https://developers.google.com/maps/documentation/embed/guide#basic_map_m...
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | edit-google-map-set-map.png | 152.88 KB | pauloamgomes |
| #8 | edit-google-maps.png | 32.65 KB | pauloamgomes |
| #2 | google_map_field-d8-basic_place_mode_formatter-3018665-2.patch | 6.67 KB | jannakha |
Comments
Comment #2
jannakha commentedComment #3
jannakha commentedComment #4
pauloamgomes commentedHi @jannakha
Many thanks for your patch, it seems to work well, however, I believe we also need a new field widget that can deal with the Embed option, are you happy to work on it or do you have other suggestion?
Comment #5
jannakha commentedHi @pauloamgomes!
cool! yeah google maps are expensive now.
All users get $200 credit to use dynamic api, so for smaller organisations that should be enough for editing maps.
But I agree, we do need a new widget for embed maps.
I'm very new to Drupal, it might take me some time to create a new widget.
I'll try to reverse engineer original widget this month or so.
What's the process of getting this patch into the main code I wonder?
Comment #6
pauloamgomes commentedI'll merge when I'm comfortable with the patch, from my verifications only the widget is missing, that doesn't affect core functionality but is a bit annoying having the google map popup in the embedded map every time we are editing the contents.
Comment #7
jannakha commentedhow do you edit content? inplace?
send me a screenshot?
Comment #8
pauloamgomes commentedSure, check below:
and when opening map set
Comment #9
vladimirausProbably good idea to create separate issue for that.
Comment #10
scot.hubbard commentedI have merged this patch in the interest of moving this ticket on so that people can have free embedded maps displayed on their sites, even if they still need billable maps to edit them.
Please raise a feature request ticket if you still want an embed widget to edit maps.
Moving to RTBC.
Comment #12
scot.hubbard commentedComment #13
scot.hubbard commented