Currently module is using SKU: Dynamic Maps which is billable. https://developers.google.com/maps/billing/understanding-cost-of-use#dyn...

We need to add SKU: Embed to make sure the user has option to select between paid and free modes.
https://developers.google.com/maps/documentation/embed/guide#basic_map_m...

CommentFileSizeAuthor
#8 edit-google-map-set-map.png152.88 KBpauloamgomes
#8 edit-google-maps.png32.65 KBpauloamgomes
#2 google_map_field-d8-basic_place_mode_formatter-3018665-2.patch6.67 KBjannakha
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

VladimirAus created an issue. See original summary.

jannakha’s picture

jannakha CreditAttribution: jannakha at Tomato Elephant Studio for Must Do Brisbane commented
Assigned: Unassigned » jannakha
Status: Active » Needs review
FileSize
google_map_field-d8-basic_place_mode_formatter-3018665-2.patch6.67 KB
jannakha’s picture

jannakha CreditAttribution: jannakha at Tomato Elephant Studio for Must Do Brisbane commented
Title: Create "Google Map Field: Basic Place Mode" formatter to use free Google Maps. » Create "Google Map Field Embed Place" formatter to use free Google Maps.
Issue summary: View changes
pauloamgomes’s picture

pauloamgomes CreditAttribution: pauloamgomes as a volunteer and at Appnovation commented

Hi @jannakha
Many thanks for your patch, it seems to work well, however, I believe we also need a new field widget that can deal with the Embed option, are you happy to work on it or do you have other suggestion?

jannakha’s picture

jannakha CreditAttribution: jannakha at Tomato Elephant Studio for Must Do Brisbane commented

Hi @pauloamgomes!
cool! yeah google maps are expensive now.
All users get $200 credit to use dynamic api, so for smaller organisations that should be enough for editing maps.
But I agree, we do need a new widget for embed maps.
I'm very new to Drupal, it might take me some time to create a new widget.
I'll try to reverse engineer original widget this month or so.

What's the process of getting this patch into the main code I wonder?

pauloamgomes’s picture

pauloamgomes CreditAttribution: pauloamgomes as a volunteer and at Appnovation commented

I'll merge when I'm comfortable with the patch, from my verifications only the widget is missing, that doesn't affect core functionality but is a bit annoying having the google map popup in the embedded map every time we are editing the contents.

jannakha’s picture

jannakha CreditAttribution: jannakha at Tomato Elephant Studio for Must Do Brisbane commented

how do you edit content? inplace?
send me a screenshot?

pauloamgomes’s picture

pauloamgomes CreditAttribution: pauloamgomes as a volunteer and at Appnovation commented
FileSize
edit-google-maps.png32.65 KB
edit-google-map-set-map.png152.88 KB

Sure, check below:

field edit

and when opening map set

set map

VladimirAus’s picture

VladimirAus
Primary language English
Location Brisbane 🇦🇺
CreditAttribution: VladimirAus at Tomato Elephant Studio for Must Do Brisbane commented

Probably good idea to create separate issue for that.

scot.hubbard’s picture

scot.hubbard CreditAttribution: scot.hubbard commented
Status: Needs review » Reviewed & tested by the community

I have merged this patch in the interest of moving this ticket on so that people can have free embedded maps displayed on their sites, even if they still need billable maps to edit them.

Please raise a feature request ticket if you still want an embed widget to edit maps.

Moving to RTBC.

  • scot.hubbard committed c132de5 on 8.x-1.x authored by JannaKha 
    Issue #3018665 by JannaKha, pauloamgomes: Create "Google Map Field Embed...
scot.hubbard’s picture

scot.hubbard CreditAttribution: scot.hubbard commented
Status: Reviewed & tested by the community » Fixed
scot.hubbard’s picture

scot.hubbard CreditAttribution: scot.hubbard commented
Status: Fixed » Closed (fixed)