Now in function happy_new_year_page_attachments() not use current year and next year.

Comments

itcrowd72 created an issue. See original summary.

aayush23’s picture

@itcrowd72, can you please explain more?

ivnish’s picture

In setting we have working period. If it checked, module will work only in this period

screenshot

In Drupal 7 version we take days and months from settings and use current year and next year.

screenshot

In Drupal 8 I lost this functionality. Now we use years from settings.

screenshot

If you save settings in current year, module will use 2018 and 2019 years. But on next NY module will stop work, because module will use 2018 and 2019 years AGAIN.

Summary:

1) Needs get days and months from settings
2) Needs use current year and next year (php function date(), not from settings)
3) Convert new dates to timestamp

aayush23’s picture

StatusFileSize
new958 bytes

Please find patch for particular issue.

ivnish’s picture

Status: Active » Needs review
ivnish’s picture

Thanks aayush23 ! I check your patch soon

ivnish’s picture

Status: Needs review » Fixed
ivnish’s picture

Status: Fixed » Closed (fixed)