Now in function happy_new_year_page_attachments() not use current year and next year.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | happy_new_year_fix_years-3017921-4.patch | 958 bytes | aayush23 |
Now in function happy_new_year_page_attachments() not use current year and next year.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | happy_new_year_fix_years-3017921-4.patch | 958 bytes | aayush23 |
Comments
Comment #2
aayush23 commented@itcrowd72, can you please explain more?
Comment #3
ivnishIn setting we have working period. If it checked, module will work only in this period
In Drupal 7 version we take days and months from settings and use current year and next year.
In Drupal 8 I lost this functionality. Now we use years from settings.
If you save settings in current year, module will use 2018 and 2019 years. But on next NY module will stop work, because module will use 2018 and 2019 years AGAIN.
Summary:
1) Needs get days and months from settings
2) Needs use current year and next year (php function date(), not from settings)
3) Convert new dates to timestamp
Comment #4
aayush23 commentedPlease find patch for particular issue.
Comment #5
ivnishComment #6
ivnishThanks aayush23 ! I check your patch soon
Comment #8
ivnishComment #9
ivnish