As a ISV (支付系统服务商), needs sys_service_provider_id to have benefits.

CommentFileSizeAuthor
#12 3016851-12.patch6.35 KBcarlxjs
#12 3016851-11-12.interdiff.txt383 bytescarlxjs
#11 3016851-11.patch5.97 KBcarlxjs
#11 3016851-10-11.interdiff.txt3.78 KBcarlxjs
#10 3016851-10.patch5.33 KBcarlxjs
#10 3016851-8-10.interdiff.txt897 bytescarlxjs
#8 3016851-8.patch5.28 KBcarlxjs
#8 3016851-7-8.interdiff.txt768 bytescarlxjs
#7 3016851-7.patch5.2 KBcarlxjs
#7 3016851-2-7.interdiff.txt7.86 KBcarlxjs
#5 PID.png50.03 KBcarlxjs
#2 3016851-2.patch3.99 KBcarlxjs

Comments

carlxjs created an issue. See original summary.

carlxjs’s picture

carlxjs commented
StatusFileSize
new 3016851-2.patch3.99 KB
carlxjs’s picture

carlxjs commented
Title: Support all optional parameters in API » Support all optional parameters in biz_content
Status: Active » Needs review
skyredwang’s picture

skyredwang
Location Shanghai
commented
Status: Needs review » Needs work

You can't just add a random parameter to a function without good reasoning.

carlxjs’s picture

carlxjs commented
Title: Support all optional parameters in biz_content » Support sys_service_provider_id in biz_content
Issue summary: View changes
StatusFileSize
new PID.png50.03 KB

As a alipay ISV, can not have benefits without the parameter sys_service_provider_id.

carlxjs’s picture

carlxjs commented
Issue summary: View changes
carlxjs’s picture

carlxjs commented
StatusFileSize
new 3016851-2-7.interdiff.txt7.86 KB
new 3016851-7.patch5.2 KB

Change the code to set sys_service_provider_id in payment gateway config.

carlxjs’s picture

carlxjs commented
StatusFileSize
new 3016851-7-8.interdiff.txt768 bytes
new 3016851-8.patch5.28 KB
carlxjs’s picture

carlxjs commented
Status: Needs work » Needs review

This patch will conflict with the patch in https://www.drupal.org/project/commerce_alipay/issues/3020894.
Both of patches in issue #3020894 and this issue #3016851 are necessary.
Please review the issue #3020894 together.

carlxjs’s picture

carlxjs commented
StatusFileSize
new 3016851-8-10.interdiff.txt897 bytes
new 3016851-10.patch5.33 KB
carlxjs’s picture

carlxjs commented
StatusFileSize
new 3016851-10-11.interdiff.txt3.78 KB
new 3016851-11.patch5.97 KB

Merge the code in in issue #3020894, add app_auth_token parameter in the request.

carlxjs’s picture

carlxjs commented
StatusFileSize
new 3016851-11-12.interdiff.txt383 bytes
new 3016851-12.patch6.35 KB

Limit the dependency, change the limit version of lokielse/omnipay-alipay.

  • skyredwang committed ae7245d on 8.x-1.x authored by carlxjs 
    Issue #3016851 by carlxjs: Support sys_service_provider_id in...
skyredwang’s picture

skyredwang
Location Shanghai
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.