Problem/Motivation

#2807785: Move global constants from *.module files into interfaces deprecated a bunch of constants but it did not actually replace their usage. We should do this. This issue handles USERNAME_MAX_LENGTH, USER_REGISTER_ADMINISTRATORS_ONLY, USER_REGISTER_VISITORS and USER_REGISTER_VISITORS_ADMINISTRATIVE_APPROVAL. This is a bug because we've deprecated something but we've not completed the task.

Proposed resolution

Use UserInterface::USERNAME_MAX_LENGTH, UserInterface::REGISTER_ADMINISTRATORS_ONLY, UserInterface::REGISTER_VISITORS and UserInterface::REGISTER_VISITORS_ADMINISTRATIVE_APPROVAL instead.

Remaining tasks

User interface changes

None

API changes

None

Data model changes

None

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

alexpott created an issue. See original summary.

alexpott’s picture

Status: Active » Needs review
FileSize
29.07 KB
alexpott’s picture

Missed some use statements.

Status: Needs review » Needs work

The last submitted patch, 3: 3015752-3.patch, failed testing. View results

alexpott’s picture

Status: Needs work » Needs review
bnjmnm’s picture

Needed reroll

bnjmnm’s picture

Status: Needs review » Reviewed & tested by the community

Reroll was simple enough that I can also review. I confirmed there were no additional uses of the deprecated constants added since the #3 patch was written, and everything else looks solid.

catch’s picture

Status: Reviewed & tested by the community » Fixed

Committed d101b4f and pushed to 8.7.x. Thanks!

  • catch committed 3cc8a61 on 8.7.x
    Issue #3015752 by alexpott, bnjmnm: Properly deprecate...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.