Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Problem/Motivation
#2807785: Move global constants from *.module files into interfaces deprecated a bunch of constants but it did not actually replace their usage. We should do this. This issue handles USERNAME_MAX_LENGTH
, USER_REGISTER_ADMINISTRATORS_ONLY
, USER_REGISTER_VISITORS
and USER_REGISTER_VISITORS_ADMINISTRATIVE_APPROVAL
. This is a bug because we've deprecated something but we've not completed the task.
Proposed resolution
Use UserInterface::USERNAME_MAX_LENGTH
, UserInterface::REGISTER_ADMINISTRATORS_ONLY
, UserInterface::REGISTER_VISITORS
and UserInterface::REGISTER_VISITORS_ADMINISTRATIVE_APPROVAL
instead.
Remaining tasks
User interface changes
None
API changes
None
Data model changes
None
Comment | File | Size | Author |
---|---|---|---|
#6 | 3015752-6.patch | 29.89 KB | bnjmnm |
#3 | 3015752-3.patch | 29.46 KB | alexpott |
#3 | 2-3-interdiff.txt | 990 bytes | alexpott |
#2 | 3015752-2.patch | 29.07 KB | alexpott |
Comments
Comment #2
alexpottComment #3
alexpottMissed some use statements.
Comment #5
alexpottThis failed due to a random fail - see #3015802: Random fail in \Drupal\Tests\Core\Transliteration\PhpTransliterationTest - retesting.
Comment #6
bnjmnmNeeded reroll
Comment #7
bnjmnmReroll was simple enough that I can also review. I confirmed there were no additional uses of the deprecated constants added since the #3 patch was written, and everything else looks solid.
Comment #8
catchCommitted d101b4f and pushed to 8.7.x. Thanks!