Problem/Motivation

It's impossible to uninstall module if the database backend is other then MySQL compatible. Attempt will result in:

$drush config:import -y
+------------+-------------------------------------+-----------+
| Collection | Config                              | Operation |
+------------+-------------------------------------+-----------+
|            | core.extension                      | Update    |
|            | search_api_attachments.admin_config | Delete    |
+------------+-------------------------------------+-----------+

 // Import the listed configuration changes?: yes.                                                                      

 [error]  SQLSTATE[42601]: Syntax error: 7 ERROR:  syntax error at or near "OPTIMIZE"
LINE 1: OPTIMIZE TABLE key_value
        ^: OPTIMIZE TABLE key_value; Array
(
)
 

Proposed resolution

Remove \Drupal::database()->query('OPTIMIZE TABLE key_value')->fetchAll(); line from search_api_attachments_uninstall() function.

Remaining tasks

  1. Patch
  2. Review
  3. Commit

User interface changes

None

API changes

None

Data model changes

None

CommentFileSizeAuthor
#3 search_api_attachments-3006891-3.patch429 bytesbramdriesen

Comments

RoSk0 created an issue. See original summary.

bramdriesen’s picture

Assigned: Unassigned » bramdriesen

Will attach patch soon.

bramdriesen’s picture

Status: Active » Needs review
StatusFileSize
new429 bytes

Patch attached, please review.

rosk0’s picture

Status: Needs review » Reviewed & tested by the community
bramdriesen’s picture

Assigned: bramdriesen » Unassigned
izus’s picture

Thanks all

  • izus committed c06c063 on 8.x-1.x authored by BramDriesen
    Issue #3006891 by BramDriesen, RoSk0, izus: Remove MySQL specific query...
izus’s picture

Status: Reviewed & tested by the community » Fixed

This is now merged
thanks again

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.