The Data Class field on the tour has a spelling error.

CommentFileSizeAuthor
#7 3006538-tour_ui-spelling_error-7.patch981 bytessean_e_dietrich
#5 before patch.png28.93 KBriddhi.addweb
#5 after patch.png29.6 KBriddhi.addweb
#4 3006538-tour_ui-spelling_error-4.patch982 bytessean_e_dietrich
#3 tour-ui-action-link.png35.14 KBclemens.tolboom
#2 3006538-tour_ui-spelling_error-2.patch982 bytessean_e_dietrich
Screen Shot 2018-10-14 at 8.25.10 AM.png148.58 KBsean_e_dietrich

Comments

sean_e_dietrich created an issue. See original summary.

sean_e_dietrich’s picture

sean_e_dietrich
he/him
Primary language English
Location Sacramento, CA
commented
Status: Active » Needs review
StatusFileSize
new 3006538-tour_ui-spelling_error-2.patch982 bytes

Suggested fix

clemens.tolboom’s picture

clemens.tolboom
Primary language Dutch
Location Groningen, 🇳🇱/🇪🇺
commented
Status: Needs review » Closed (works as designed)
StatusFileSize
new tour-ui-action-link.png35.14 KB

That's not a spelling error. I filled in the same value into the field. It then reads in full .action-links a[href="/admin/structure/forum/add/forum"].

Feel free to reopen :)

sean_e_dietrich’s picture

sean_e_dietrich
he/him
Primary language English
Location Sacramento, CA
commented
Status: Closed (works as designed) » Needs review
StatusFileSize
new 3006538-tour_ui-spelling_error-4.patch982 bytes

Ok, that I understand but this also includes fixing complexe to complete. New patch submitted.

riddhi.addweb’s picture

riddhi.addweb commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new after patch.png29.6 KB
new before patch.png28.93 KB

@sean_e_dietrich, Thanks for solving this typo issue, it updates the typo successfully, when I checked it using simplytest.me. PFA

clemens.tolboom’s picture

clemens.tolboom
Primary language Dutch
Location Groningen, 🇳🇱/🇪🇺
commented
Status: Reviewed & tested by the community » Needs work

Lol ... complexe is wrong but is it a 'more complex' or 'more complete'

Reading https://wikidiff.com/complex/complete

Ideas thus made up of several simple ones put together, I call complex ; such as beauty, gratitude, a man, an army, the universe.
Not simple, easy, or straightforward; complicated.

I think it's more about several simple parts put together.

What do you think?

@riddhi.addweb thanks for testing. Do you know you can embed uploaded images and even edit your comment :-)

sean_e_dietrich’s picture

sean_e_dietrich
he/him
Primary language English
Location Sacramento, CA
commented
Status: Needs work » Needs review
StatusFileSize
new 3006538-tour_ui-spelling_error-7.patch981 bytes

WOW I oddly saw more complete instead of complex.

New patch uploaded

clemens.tolboom’s picture

clemens.tolboom
Primary language Dutch
Location Groningen, 🇳🇱/🇪🇺
commented

@riddhi.addweb I removed you from the credits. I'd like to see something more then before/after PNGs from you. Checking https://www.drupal.org/u/riddhiaddweb I mostly see this pattern.

clemens.tolboom’s picture

clemens.tolboom
Primary language Dutch
Location Groningen, 🇳🇱/🇪🇺
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.