Problem/Motivation

I can remove the node, even when I should not.

Proposed resolution

Check permission before generate "additional action" form element and hide the "Remove node" option if the user does not have permission to delete a specific type of node.

CommentFileSizeAuthor
#5 interdiff-4-5.txt2.16 KBlamp5
#5 merge_translations-check-delete-access-3004569-5.patch5.1 KBlamp5
#4 merge_translations-check-delete-access-3004569-4.patch4.72 KBkrzysztof domański
#3 merge_translations-check-delete-access-3004569-3.patch4.9 KBkrzysztof domański

Comments

Krzysztof Domański created an issue. See original summary.

stborchert’s picture

stborchert
he/him
Primary language German
commented

This has to be done on a per-node-basis also (in removeNode()) as it may happen that you are not allowed to delete a single node.

krzysztof domański’s picture

krzysztof domański
Location Poland
commented
Version: » 8.x-1.x-dev
Status: Active » Needs review
StatusFileSize
new merge_translations-check-delete-access-3004569-3.patch4.9 KB
krzysztof domański’s picture

krzysztof domański
Location Poland
commented
Priority: Normal » Major
StatusFileSize
new merge_translations-check-delete-access-3004569-4.patch4.72 KB

Update. Last patch is out of date.

lamp5’s picture

lamp5
Primary language Polish
Location Rzeszow
commented
StatusFileSize
new merge_translations-check-delete-access-3004569-5.patch5.1 KB
new interdiff-4-5.txt2.16 KB

I reviewed this patch and tested it. I added small fixes for it.

  • lamp5 committed 935c2e5 on 8.x-1.x 
    Issue #3004569 by Krzysztof Domański, lamp5: Do not allow nodes to be...
lamp5’s picture

lamp5
Primary language Polish
Location Rzeszow
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.