All dependencies must be prefixed by project name, So please apply new {project}:{module} format for dephttps://www.drupal.org/docs/8/creating-custom-modules/let-drupal-8-know-... in info.yml filehttps://www.drupal.org/docs/8/creating-custom-modules/let-drupal-8-know-about-your-module-with-an-infoyml-file

It is supported since 8.0 and 7.40 Change Record: Project namespaces can now be added for module dependencies, and is now a Best Practice Define project dependencies in core module .info files).

It is useful for Installation profiles to work well. So sooner is better.
Hope this helps.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

chipway created an issue. See original summary.

chipway’s picture

Assigned: chipway » Unassigned
Status: Needs work » Needs review
StatusFileSize
new357 bytes

Here is the patch. Please review.

I also added the missing last empty line.

alonaoneill’s picture

Status: Needs review » Reviewed & tested by the community

Code looks good. The dependency namespacing aligns with Drupal documentation standards.
Patch applied via simplytest.me
Marking as RTBC
Thank you for working on module!

pbonnefoi made their first commit to this issue’s fork.

  • pbonnefoi committed 396a831f on 8.x-2.x
    Issue #3003487 by pbonnefoi, chipway: All dependencies must be prefixed
    

  • pbonnefoi committed 155c231b on 3.0.x
    Issue #3003487 by pbonnefoi, chipway: All dependencies must be prefixed
    
pbonnefoi’s picture

Status: Reviewed & tested by the community » Fixed

Thanks, it was merged and released in both 8.x-2.3 a,d 3.0.0. Thanks @chipway

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.