I'm suggesting to change domain_id to domain in configuration form route and getting domain not from request object.

Comments

david.pashaev created an issue. See original summary.

davps’s picture

Issue summary: View changes
davps’s picture

Assigned: davps » Unassigned
Status: Active » Needs review
StatusFileSize
new2.29 KB
davps’s picture

Version: 8.x-1.1 » 8.x-1.x-dev
vuil’s picture

Status: Needs review » Closed (works as designed)
davps’s picture

Status: Closed (works as designed) » Needs review

@ilchovuchkov, why are you thinking that this works as designed? Have you read this article?

malaynayak’s picture

Status: Needs review » Closed (won't fix)
malaynayak’s picture

Status: Closed (won't fix) » Closed (works as designed)
vuil’s picture

Status: Closed (works as designed) » Needs work

As of #3 & #4 I re-open and back the issue to Needs work. As much as possible code reviews are welcome. :)

vuil’s picture

Issue tags: +Needs reroll
ravi.kiran’s picture

Re-rolled patch in #3 against 8.x-1.x
Please review.

ravi.kiran’s picture

Status: Needs work » Needs review
jeroent’s picture

Issue tags: -Needs reroll
StatusFileSize
new2.29 KB

  • JeroenT committed a66721e on 8.x-1.x
    Issue #3003463 by davps, ravi.kiran, JeroenT: Config form route argument
    
jeroent’s picture

Status: Needs review » Fixed

Committed and pushed to 8.x-1.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.