I'm thinking the 1.0 release for D6 might be a little bit premature. I upgraded to 1.0 from the previous release just fine, but a couple hours later I decided to start the sites over database-wise, so I emptied out the database and went back to install.php. When I went to re-enable the DA module, though, the "Too many HTTP redirects" problem pops up immediately after enabling the module. (I suspect "Too many HTTP redirects" is Omniweb's and/or Webkit's specific verbiage for the problem, but what's happening should still be apparent; the browser is getting bounced around too much by HTTP headers and is giving up instead of continuing indefintely.)

If I disable the module manually in the {system} table, I can get access to the site back, but this status message appears about twenty times:

You have followed an incorrect link to this website. Please update your links and bookmarks to http:///sbdc/admin/build/modules.

When this was happening, I was accessing the site through my computer's IP address on the office LAN (http://192.168.1.170/sbdc/). That part of the address seems to be missing from the message above.

Just to be sure, I tried a virgin install of D6.4 with no other modules and themes, then went to admin/build/modules and enabled just the Domain Access module (no submodules); the same problem occurred.

CommentFileSizeAuthor
#2 domain.patch675 bytesGarrett Albright

Comments

Garrett Albright’s picture

Garrett Albright commented
Status: Needs review » Active

Hmm, interesting. If I try to enable the module while using Firefox 2, instead of an HTTP redirect problem, the browser tries to go to http://sbdc/admin/build/modules, which causes a generic "Server not found" error. It looks like the two browsers are interpreting whatever header Domain Access is throwing at them in different ways.

Garrett Albright’s picture

Garrett Albright commented
Title: "Too many HTTP redirects" on fresh installation » Fresh installation causing nasty problems
Priority: Normal » Critical
Status: Active » Needs review
StatusFileSize
new domain.patch675 bytes

I fixed it…?

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Status: Active » Needs review

This is what happens when other people don't test patches!

It looks like #293453: Wildcard DNS - default domain broke this. BUT NO ONE TESTED IT.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented

For now, comment out line 63 domain.module:

      drupal_set_message(t('You have followed an incorrect link to this website.  Please update your links and bookmarks to <a href="!url">!url</a>.', array('!url' => $request)));
   #   drupal_goto($request);
agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented

The patch in #2 is likely the safest solution. Is the $_SERVER['HTTP_HOST'] variable reliable across all versions of PHP?

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Status: Needs review » Fixed

Fixed in 6.x.1.1 and 5.x.1.7.

I went a different way with the fix, simply ensuring that a value was present. The problem with the patch in #2 is that if you hit the site from one.example.com, that will be stored (incorrectly) as the primary domain. Better to bypass the redirect if the value is not set.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.