Currently the synchronizer service provides both info regarding synchronizations and carries them out. Any CRUD operations regarding group roles should take place in the storage. So here's the proposed plan of action:

  1. Move the service CRUD code to the group role storage
  2. Adjust tests accordingly
  3. Move the group role CRUD code in GroupType::postSave() to the group role storage as well
  4. Call this move code everywhere it makes sense (like we do for synchronized roles)
CommentFileSizeAuthor
#2 group-2995058-2.patch36.87 KBkristiaanvandeneynde

Comments

kristiaanvandeneynde created an issue. See original summary.

kristiaanvandeneynde’s picture

kristiaanvandeneynde
Primary language Dutch
Location Antwerp, Belgium
commented
Status: Active » Needs review
StatusFileSize
new group-2995058-2.patch36.87 KB

Status: Needs review » Needs work

The last submitted patch, 2: group-2995058-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

  • f390afc committed on 8.x-1.x 
    Issue #2995058 by kristiaanvandeneynde: Separate concerns for the group...
kristiaanvandeneynde’s picture

kristiaanvandeneynde
Primary language Dutch
Location Antwerp, Belgium
commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.