Closed (fixed)
Project:
Slack
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Reporter:
Created:
21 Aug 2018 at 09:47 UTC
Updated:
19 Feb 2026 at 01:12 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
facine commentedAttach a patch with the code.
Comment #3
manuel garcia commentedI think this is a great idea.
Some thoughts after a read of the patch:
advancedqueueby the looks of it.advancedqueuemodule can be done as an iteration of this if people want it. Up to the maintainers of course.I believe these to be incorrect since
advancedqueueis not a requirement:This will blow up if
advancedqueueis not installed.This will blow up if
advancedqueueis not installed.Comment #4
vuilAdd a separate issue about the first point of Proposed resolution in summary:
(1) #3072863: Add the composer file
Comment #5
manuel garcia commentedComment #6
tr commentedChanged #2 to point to issue #3170952: Configuration schema is invalid
Patch needs to be re-rolled.
Why add the dependency on the contributed module advancedqueue, instead of using a core QueueWorker plugin?
Comment #7
facine commented@Manuel Garcia, thank you for reviewing this.
I'm attaching a new approach without advancedqueue dependency.
Comment #9
facine commentedFixing coding standard
Comment #11
facine commentedComment #12
smustgrave commentedNeeds a reroll
Comment #13
facine commentedComment #16
swirtI created a MR from the patch in #13 with some minor re-rolling.
Comment #17
swirtComment #19
swirtThis has been merged. Thank you facine for keeping this dream alive for 8 years. It is a valuable improvement.
Comment #21
swirtThis was released as 8.x-1.6
Comment #22
swirt