According to Drupal standards, modules should include dependencies in the .info.yml file.
Dependencies should be namespaced in the format {project}:{module}, where {project} is the project name as it appears in the Drupal.org URL (e.g. drupal.org/project/views) and {module} is the module's machine name.

https://www.drupal.org/docs/8/creating-custom-modules/let-drupal-8-know-...

CommentFileSizeAuthor
#2 icn-namespacing-2992859-2.patch249 bytesalonaoneill

Comments

alonaoneill created an issue. See original summary.

alonaoneill’s picture

alonaoneill commented
Assigned: alonaoneill » Unassigned
Status: Active » Needs review
StatusFileSize
new icn-namespacing-2992859-2.patch249 bytes

I uploaded a patch that corrects the dependency namespacing in the .info.yml file.
Thanks!

volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
commented
Status: Needs review » Reviewed & tested by the community

Patch applied via simplytest.me.

Code looks good and the dependency namespacing issue is addressed according to Drupal documentation standards. Marking RTBC.

drdam’s picture

drdam commented

Thanks,
I commit this ASAP

  • alonaoneill authored 8310247 on 8.x-1.x 
    Issue #2992859 by alonaoneill: Dependency namespacing in .info.yml file
drdam’s picture

drdam commented
Status: Reviewed & tested by the community » Fixed
drdam’s picture

drdam commented
Status: Fixed » Closed (fixed)
drdam’s picture

drdam commented

Released in 1.3