Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.| Comment | File | Size | Author |
|---|---|---|---|
| #8 | 2989519-8.patch | 32.47 KB | tstoeckler |
Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.| Comment | File | Size | Author |
|---|---|---|---|
| #8 | 2989519-8.patch | 32.47 KB | tstoeckler |
Comments
Comment #2
tstoecklerHere we go. This should already work, as far as I can tell. The problem is that it incurs a significant performance cost, because all of the dependencies for the optional config need to be checked at runtime, including for a config read. So I will not commit this as is.
However, because the set of valid optional config really only depends on the extension list I think we should be able to perform some nice caching. Maybe that will even make sense for the install config, not sure yet.
Also found #2994828: Enforced config dependencies override normal dependencies instead of adding to them when working on this, BTW.
Comment #3
tstoecklerFound a bug in
::filterDelete(). It's unrelated to this issue, but this already touches so many pieces of code, I guess we might as well fix it here.Also fixes the remaining coding standard issues that are in 8.x-1.x at the moment.
Does not yet address the performance issue raised in #2.
Comment #5
tstoecklerOK, so this revamps the whole "modifying the source/file storage" thing a bit. Hopefully this is green. Also opened #2995099: Extract parts of FileStorage::write() into a ::writeEncoded() method along the way.
Comment #6
tstoecklerHere we go, this should address the performance concern by hooking into the storage class directly.
Comment #8
tstoecklerOops, small oversight. Will commit this if green.
Comment #10
tstoeckler