When purging if the response from Fastly API is not an array the following error is thrown:

count(): Parameter must be an array or an object that implements Countable Api.php:251 [warning]

CommentFileSizeAuthor
#6 fastly_wrong_response_type_2978860.patch800 bytesvalic
#2 fastly-purge-warnings-2978860-2.patch1.12 KBkasperg

Comments

kasperg created an issue. See original summary.

kasperg’s picture

kasperg commented
Status: Active » Needs review
StatusFileSize
new fastly-purge-warnings-2978860-2.patch1.12 KB

Here is a patch that adds additional type checking for the response. If it is not an array we treat is as an error.

vvuksan-fastly’s picture

vvuksan-fastly commented
Status: Needs review » Fixed

Commited.

vvuksan-fastly’s picture

vvuksan-fastly commented
Status: Fixed » Closed (fixed)
gg4’s picture

gg4 commented 
+++ b/src/Api.php
@@ -248,7 +248,7 @@ class Api {
+        if (is_array($result) && count($result) > 0) {

This is highly problematic.

$result is an object in this case, not an array.

This change should be reverted ASAP.

valic’s picture

valic
Primary language Croatian
Location Osijek
commented
StatusFileSize
new fastly_wrong_response_type_2978860.patch800 bytes

We could add check if is object and then convert it to array (I am using attached patch).

gg4’s picture

gg4 commented

@valic this issue is marked as closed and the change has been reverted. It is probably best to create a new issue explaining the benefits of that approach and the problem it solves.