Problem/Motivation

Some times parameter $javascript in jquery_dollar_js_alter() come empty, this throw a notice:
Notice: Undefined index: core/misc/drupal.init.js in jquery_dollar_js_alter() (line 16 of modules/contrib/jquery_dollar/jquery_dollar.module).

Proposed resolution

I propose add a previous verification before use the parameter $javascript.

Remaining tasks

Commit the path :D

User interface changes

No

API changes

No

Data model changes

No

CommentFileSizeAuthor
jquery_dollar-undefined_index--8.x-1.x-dev.patch1.01 KBpsf_

Comments

psf_ created an issue. See original summary.

psf_’s picture

psf_ commented
Status: Active » Needs review
gustavowal’s picture

gustavowal commented

The isset from jquery_dollar-undefined_index--8.x-1.x-dev.patch seems to resolve the warnings. +1

joaopauloscho’s picture

joaopauloscho commented
Status: Needs review » Reviewed & tested by the community

It works for me too.

  • gueguerreiro committed 2574cdc on 8.x-1.x authored by psf_ 
    Issue #2977509 by psf_, gueguerreiro: Undefined index: core/misc/drupal....
gueguerreiro’s picture

gueguerreiro
Primary language Portuguese, Portugal
Location Lisboa
commented
Status: Reviewed & tested by the community » Fixed

Thank you @psf_. Your changes are now in the 8.x1.1 release of the module.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.