We need to port the D7 feeds_tamper Encode plugin to D8 tamper.

CommentFileSizeAuthor
#10 interdiff_6-10.txt2.9 KBzabej
#10 encode-2976173-10.patch5.47 KBzabej
#6 interdiff_4-6.txt426 bytesvijay.mayilsamy
#6 encode-2976173-6.patch5.24 KBvijay.mayilsamy
#4 encode-2976173-4.patch5.21 KBjamesdixon
#3 encode-2976173-3.patch6.99 KBjamesdixon
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jamesdixon created an issue. See original summary.

jamesdixon’s picture

jamesdixon CreditAttribution: jamesdixon at Dialed In Design commented
Parent issue: » #2958013: [META] port remaining feeds tamper plugins
jamesdixon’s picture

jamesdixon CreditAttribution: jamesdixon at Dialed In Design commented
Status: Active » Needs work
FileSize
encode-2976173-3.patch6.99 KB

Made a big dent on this one. Just need to wrap up changing tests to actual encode tests (the test cases are placeholders from convert case plugin tests).

jamesdixon’s picture

jamesdixon CreditAttribution: jamesdixon at Dialed In Design commented
Status: Needs work » Needs review
FileSize
encode-2976173-4.patch5.21 KB

Okay I think this one is ready to go!

ericgsmith’s picture

ericgsmith CreditAttribution: ericgsmith as a volunteer commented

Thanks James,

This looking good - haven't given it a full test, but am wondering on something.

Drupal 8 has a Serialization component, which contains an interface and implementations for php serialize, json and yaml. I'm wondering if for now we proceed with your implementation, but at some stage it might be worth looking at splitting out some of the functionality into a serialize tamper plugin, using the d8 components. Happy to proceed with this plugin as is and look at that for a future release.

+++ b/src/Plugin/Tamper/Encode.php
@@ -0,0 +1,84 @@
+ * @Tamper(

I think we need the handle_multiples = TRUE annotation so that feeds tamper will not loop through the individual values.

vijay.mayilsamy’s picture

vijay.mayilsamy CreditAttribution: vijay.mayilsamy as a volunteer and at Dialed In Design commented
FileSize
encode-2976173-6.patch5.24 KB
interdiff_4-6.txt426 bytes

Hi Eric,

Here is the updated patch and interdiff file after changes. handle_multiple is added to annotations.

Thanks
Vijay

volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
CreditAttribution: volkswagenchick at Kanopi Studios commented
Issue tags: +dcasheville19

Tagging for DrupalCamp Asheville

volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
CreditAttribution: volkswagenchick at Kanopi Studios commented
Issue tags: +dcco2019

Tagging for the next to North American contrib days, Asheville and Colorado

DrupalCamp Asheville contrib days are July 13-14, 2019
DrupalCamp Colorado contrib day is Aug 4, 2019

jamesdixon’s picture

jamesdixon CreditAttribution: jamesdixon at Dialed In Design commented

1) We need to reroll this with the latest tests (ie: add that 4th parameter when creating a test object)
2) Test to see this is still passing tests
3) Review
4) Commit

I'll handle 3 and 4.

zabej’s picture

zabej CreditAttribution: zabej as a volunteer commented
FileSize
encode-2976173-10.patch5.47 KB
interdiff_6-10.txt2.9 KB

Hello @jamesdixon,

Added forth parameter and run local tests. Please review

  • jamesdixon committed 3caa8b9 on 8.x-1.x authored by zabej 
    Issue #2976173 by jamesdixon, vijay.mayilsamy, zabej, ericgsmith: Encode...
jamesdixon’s picture

jamesdixon CreditAttribution: jamesdixon at Dialed In Design commented

Looks good thanks for updating this. Nice work everyone.

This has been committed to 8.x-1.x.

commit 3caa8b928907ec4b9d403e55d2636c7297a2f9fa

jamesdixon’s picture

jamesdixon CreditAttribution: jamesdixon at Dialed In Design commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.