Problem/Motivation

#2969363: Add a drupalci.yml to core landed, adding a core/drupalci.yml file that says this:

      # Re-run composer install to ensure the dependencies resolve for the
      # containerized PHP version.
      container_composer:
        options: ' install --prefer-dist --no-suggest --no-progress --no-interaction'
        halt-on-fail: true

Just as this happened, we also made this change to the testbot: #2971239: Invert build to create environment first

This change ensures that the assemble_codebase step happens within the containerized PHP. See the default build file: https://cgit.drupalcode.org/drupalci_testbot/tree/build_definitions/deve...

This means we don't need to re-run composer install in our drupalci.yml file.

This isn't a bug, it just means that we run composer install more than we need to.

Proposed resolution

Remove the call to assessment:validate_codebase:container_composer from core/drupalci.yml.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#3 2974033-3.patch528 bytesjibran

Comments

Mile23 created an issue. See original summary.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Active » Needs review
StatusFileSize
new 2974033-3.patch528 bytes

Here you go.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented

The example file at https://www.drupal.org/drupalorg/docs/drupal-ci/customizing-drupalci-tes... also needs an update once this issue is fixed.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Reviewed & tested by the community

Compared the output of this run to a run of another patch and this part is now missing, but the build is still fine:

14:12:32 ----------------   Starting container_composer   ----------------
14:12:32 Directory created at /var/lib/drupalci/workspace/jenkins-drupal_patches-73872/ancillary/container_composer
14:12:32 ---------------- Finished container_composer in 0.009 seconds ----------------

Shaving off 0.009 seconds won't change the world but still we might as well remove this.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed ee719dc and pushed to 8.7.x. Thanks!

  • alexpott committed ee719dc on 8.7.x 
    Issue #2974033 by jibran, Mile23, longwave: drupalci.yml no longer needs...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.