Closed (fixed)
Project:
Minify
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
27 Apr 2018 at 02:01 UTC
Updated:
19 Jan 2020 at 07:59 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
fluidstack commentedwhen using php7.2
Comment #3
jalpesh commentedYou can try this patch.
Comment #4
fluidstack commentedThanks jalpesh! Patch works.
Comment #5
bojan_dev commentedWith the above patch I got the following warning:
"count(): Parameter must be an array or an object that implements Countable in _minify_reserve_place()"
For readability reasons I have added a new variable "placeholder_count", which check first if the global placeholders is an array and then does a count.
Comment #6
Dieter Geiling commented@bojan_dev
Thanks mate - your patch is working for me!
Comment #7
daveianoPatch #5 also works for me, is looking good!
Comment #8
ronaldmulero commentedPatch #5 works for me. Thanks.
Comment #9
sgdev commentedPatch in #5 does not apply cleanly. It references a "new file" called php7count_2967902.patch that does not exist.
Have cleaned up #5 so it works correctly.
Comment #10
nairb commentedThanks! Works for me.
Comment #12
atul.bhosale commentedComment #13
atul.bhosale commentedComment #15
atul.bhosale commented