Comments

fluidstack created an issue. See original summary.

fluidstack’s picture

when using php7.2

jalpesh’s picture

Status: Active » Needs review
StatusFileSize
new616 bytes

You can try this patch.

fluidstack’s picture

Thanks jalpesh! Patch works.

bojan_dev’s picture

StatusFileSize
new643 bytes

With the above patch I got the following warning:
"count(): Parameter must be an array or an object that implements Countable in _minify_reserve_place()"

For readability reasons I have added a new variable "placeholder_count", which check first if the global placeholders is an array and then does a count.

Dieter Geiling’s picture

@bojan_dev
Thanks mate - your patch is working for me!

daveiano’s picture

Status: Needs review » Reviewed & tested by the community

Patch #5 also works for me, is looking good!

ronaldmulero’s picture

Patch #5 works for me. Thanks.

sgdev’s picture

Version: 7.x-1.5 » 7.x-1.x-dev
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new1.04 KB

Patch in #5 does not apply cleanly. It references a "new file" called php7count_2967902.patch that does not exist.

Have cleaned up #5 so it works correctly.

nairb’s picture

Status: Needs review » Reviewed & tested by the community

Thanks! Works for me.

  • atul.bhosale committed 0655b44 on 7.x-1.x
    Issue #2966657 by jalpesh:  Warning: count(): Parameter must be an array...
atul.bhosale’s picture

atul.bhosale’s picture

Status: Reviewed & tested by the community » Fixed

  • atul.bhosale committed 584738a on 7.x-1.x
    Issue #2966657 by bojan_dev:  Warning: count(): Parameter must be an...
atul.bhosale’s picture

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.