Put the big empty textarea into a collapsed details element, and open it if there's anything inside (regression from D7).

CommentFileSizeAuthor
#8 devel_php-form_details-2962993-8.patch2.15 KBgrimreaper
#2 devel-tune-ExecutePHP-2962993-2-D8.patch1.95 KBsalvis

Comments

salvis created an issue. See original summary.

salvis’s picture

salvis
he/his
commented
Status: Active » Needs review
StatusFileSize
new devel-tune-ExecutePHP-2962993-2-D8.patch1.95 KB

Here's the patch, as well as some more minor clean-up.

moshe weitzman’s picture

moshe weitzman commented
Status: Needs review » Closed (won't fix)

[#3005475: Remove Execute PHP feature]

geek-merlin’s picture

geek-merlin
Primary language German
Location Freiburg, Germany
commented
Project: Devel » Devel PHP
Component: devel » Code
Status: Closed (won't fix) » Needs work

Code moved due to #3005475-15: Remove Execute PHP feature.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented

Hello,

Sorry, but I don't see the point to put the textarea into a details element, except that may had been a D7 behavior.

It adds an extra step to be able to use the form.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Category: Bug report » Feature request
Status: Needs work » Postponed (maintainer needs more info)
geek-merlin’s picture

geek-merlin
Primary language German
Location Freiburg, Germany
commented

+1 for #5/wontfix.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: salvis » Unassigned
Status: Postponed (maintainer needs more info) » Needs review
StatusFileSize
new devel_php-form_details-2962993-8.patch2.15 KB

Hello,

I think I understand the need now.

It is when the form is in the block. As there are 20 rows in the texarea it has an important height.

Here is a rework of the patch. So when using the /devel/php page, you don't have an additional click to do.

Thanks for the review.

salvis’s picture

salvis
he/his
commented
Status: Needs review » Reviewed & tested by the community

Yes, exactly!

I always use the block, never the page, and I completely forgot about the page.

Thanks a lot, Grimreaper!

  • Grimreaper committed 9909b50 on 8.x-1.x 
    Issue #2962993 by salvis, geek-merlin, Grimreaper: Tune the Execute PHP...
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Status: Reviewed & tested by the community » Fixed

Hi Salvis,

Thanks for the feedback.

This is merged now!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.