Delete reminder with Rules

@munchousen

Unfortunately, I'm not much of a Drupal guru. In particular not the rules API. I'm also not exactly sure what you want to do.

What do you mean by "when a registration is made?" Is that an action from another module? Registrations, perhaps?

And do you want to delete *all* reminders on the node? Or just the user that's doing the registration? I'm not sure why you'd want that, but OK.

Something like "delete all reminders for user X" might be possible, but you'd want to be sure that the current user had appropriate ability.

Or "delete all reminders on this node," but again, I think you'd want to ensure that the current user was able to write the node.

A bit more detail of just what you want to do would help.

Sorry for not responding earlier. (1) I haven't been actively working on drupal for a while and (2) for some reason my email client tends to send drupal notices to the junk box, in spite of how many times I move messages back to my inbox.

That said...

Implementing deletes for "all for this node," "all for this user," or "all for this node and user" wouldn't be too hard to implement within the module. I'm a little concerned about permissions; I wouldn't want to open a back door that let a random user delete other users' reminders. It's been a while since I dealt with rules, so I'm not sure how to protect against that.

I'll be thinking about it, but can't guarantee any deadline.

Looking at how permissions work (at least as currently used in DateReminder), permissions are based on who is executing the action, not on who set up the rule.

My understanding is that, when an unprivileged user registers for an event, you want a rule to be triggered to delete all reminders for that event. So that user would be (indirectly) causing something to happen (deleting someone else's reminders) that shouldn't be permitted. If we could ensure that only a site administrator (or maybe someone with permission to modify a mode) could configure such a rule, that would probably be OK, but again, I'm not so sure about that. Is there a concept of "permission to even know about this rule?"

Maybe the clean-up could be done in a cron job (running as a privileged user) could do the cleanup, but that seems kludgy, too.

Some thought required.

Ah, I find that there is an ''access callback" option in hook_rules_action(), so yes, we could ensure that only suitably-privileged users could configure a given rule. That's probably secure enough.

Unfortunately, I have a pretty good understanding of what you want. What I'm lacking is the spare time to work on it. After being out of commission for a couple of months, I have a lot of catching up to do in "real life."

So this doesn't sound too hard. Just hasn't bubbled up on my list.

Now, if you're at all comfortable with PHP and Drupal, and wanted to submit a patch, I'd be happy to look at it. Basically, what's needed is one or more new action descriptions added to the list here, defining a new action datereminder_rules_action_delete_all_node_reminders. The new datereminder_rules_action_info entry would be similar to datereminder_rules_action_set_enable_reminder, but with only the first parameter. The added complication would be figuring out how to do the "access callback" to ensure only a user with the specified privilege could use that rule.

The code to delete reminders for a node should be fairly simple, basically a call to _datereminder_clean_node_reminders().

OK, munchausen, I've made the change that I think will do what you want, basically created a rule action to delete all reminders for a node. It will only appear in the menu for users with permission to administer reminders. (We could define a separate permission for that, but I think that's overkill.)

It doesn't appear on the releases page (at least not at the moment) but here's a link: https://www.drupal.org/project/datereminder/releases/7.x-1.x-dev

I think that version has the new rule. (Drupal's version management has changed since I last was heavily into this, and I don't see how to control appearance of development releases in the list of releases.

Please try it out and see if it does what you want.

Oops. Wrong parameter in a function call. Just checked in a fix. The dev release has the change. Give it a try.

Fixed in release 7.x-1.14.