Migrate gender field

I went ahead and did the boring work of adding the additional options from the gender list to the widget. Looking at it now, it does occur to me that perhaps a select/multi-select would be better than radios/checkboxes, just due to the length of the widget.

Screenshot and patch files are attached.

@krismaye - To apply a patch, first you'll need to reset your local repository:

# Make sure you're in the gender module directory first!
git reset
git checkout .

And you might also need to remove the src directory, since it isn't being tracked yet:

# No really, make sure you're in the gender module directory first!
rm -rf src

Then you should be able to apply the patch with:

git apply gender-migrate-field-2960779-5-8.patch

If that doesn't work, which sometimes it doesn't because git is weird, try using:

patch -p1 < gender-migrate-field-2960779-5-8.patch

That should get you up to date with the changes I've made. From there you can proceed as normal and create an interdiff between my patch and the next patch you create.

If you run into any trouble or if you're just not comfortable with doing any of that, feel free to reach out to me on Slack.

I think Chosen should just integrate out of the box if we use a select/multi-select field, shouldn't it?

We could look into adding an optional dependency on the Chosen module that, if it's present, automatically configures the field to use Chosen? Maybe even make that configurable, and perhaps on by default, but have it so users can disable it if they'd prefer to not use Chosen for it.

Okay, I figured it out. I kept it based on an options widget, but changed it to a select widget. I also had to do some tweaking to the FieldType class get it to accept the values, instead of not storing them or complaining that the entered values were invalid.

I'm inclined to leave them in the order that they're in. I we pulled them straight from the Open Demographics project's gender page.

Uploading a new patch that fixes some coding standards issues. Unless anybody has any objections, I think this is about ready to go.

I switched it over to ListItemBase - I assume that's what you meant, since ListStringItem extends ListItemBase, and both ListItemBase and StringItemBase extend FieldItemBase, so using StringItemBase seems like it wouldn't be appropriate, unless I'm missing something here.

It was an easy change to make, so I figured we should knock it out now instead of leaving it as a to-do.

For what it's worth, I do think it's a little silly, though - one of the benefits of the switch to the OOP structure is being able to extend and override classes, but not these classes, because reasons. So copy and paste a bunch of code out of those classes and into your classes. That was literally the solution: copy and paste the extra methods out of ListStringItem and into the Gender field type class.

/shrug

Re: tests, we have an issue for that already, #2960781: Add tests for Drupal 8 field.

I tested Chosen, and we don't need to do anything to integrate with it. With the default Chosen settings, it enables it on all select fields, so it works right out of the box.

I'm okay with merging this in and calling it alpha1. Anybody have any objections?

I went ahead and merged it in since it works and there's at least 3 other issues pending on it. If we find problems with the work done so far, we can open new issues for those.

Thanks everyone!