Problem/Motivation

The method on the stroage filter \Drupal\config_sync\Plugin\ConfigFilter\SyncFilter::filterCreateCollection is used on multilingual sites. But it doesn't invoke the constructor properly.

Proposed resolution

Make the initSyncSourceStorage method static and call it in create()

Remaining tasks

tests..

User interface changes

na

API changes

na

Data model changes

na

CommentFileSizeAuthor
#2 2959221-1.patch3.68 KBbircher

Comments

bircher created an issue. See original summary.

bircher’s picture

bircher
Location 🇨🇿
commented
Status: Active » Needs review
StatusFileSize
new 2959221-1.patch3.68 KB

Attached the proposed solution

nedjo’s picture

nedjo
he/him/his
Primary language English
commented

Thanks!

The task of adding test coverage is, ahem, not helped by the complete lack of existing tests.

nedjo’s picture

nedjo
he/him/his
Primary language English
commented

@bircher: I'd like to get this in and into a release, so I'm thinking we can merge it and leave this issue open pending test coverage. Thoughts?

  • nedjo committed 5e561a5 on 8.x-2.x authored by bircher 
    Issue #2959221 by bircher: filterCreateCollection is not working as...
nedjo’s picture

nedjo
he/him/his
Primary language English
commented
Status: Needs review » Fixed

Committed, thanks!

Test coverage pending #2429953: Write tests.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.