The code of this module is not as per Drupal coding standards. It would be nice to follow Drupal coding standards.
Let's update the whole module to adhere to D7 code standards (that were probably set since the last commit).

CommentFileSizeAuthor
#4 2957504-4.patch13.37 KByogeshmpawar
#2 2957504-2.patch14.78 KBsonvir249

Comments

sonvir249 created an issue. See original summary.

sonvir249’s picture

sonvir249 commented
StatusFileSize
new 2957504-2.patch14.78 KB
yogeshmpawar’s picture

yogeshmpawar
He/Him/His
Primary language English
Location Pune(MH), INDIA 🇮🇳
commented
Status: Active » Needs work

@sonvir249 - Can you please update the patch because of this commit your patch is failed to apply on 7.x-1.x branch

yogeshmpawar’s picture

yogeshmpawar
He/Him/His
Primary language English
Location Pune(MH), INDIA 🇮🇳
commented
Status: Needs work » Needs review
StatusFileSize
new 2957504-4.patch13.37 KB

Here is the updated patch for this issue.

  • Yogesh Pawar committed 0ca64e8 on 7.x-1.x 
    Issue #2957504 by sonvir249, Yogesh Pawar: Drupal code standards update
yogeshmpawar’s picture

yogeshmpawar
He/Him/His
Primary language English
Location Pune(MH), INDIA 🇮🇳
commented
Status: Needs review » Fixed

Committed & Pushed to 7.x-1.x branch.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.