When installing either 1.x or 1.x-dev, it appears the settings form is unable to save with any value, complaining that "Line height is not a valid number."

Here's a screenshot of what I'm describing: https://www.evernote.com/l/AIDwYV3V0GBEubrDhDiLo9IUGYC5u-hGKgA.

When I change the settings form widget type to 'textfield', it appears to work as expected and is able to save, and I can see the line height setting taking effect on my CKEditors. It appears the problem is the 'number' widget. I have submitted a patch for this, and was hoping to get maintainer input / feedback, to make sure I haven't missed anything in the intended usage of the module.

Drupal version : 8.5.0-rc1

CommentFileSizeAuthor
#2 line-height-settings-form-change.patch526 bytestwfahey

Comments

twfahey created an issue. See original summary.

twfahey’s picture

twfahey commented
StatusFileSize
new line-height-settings-form-change.patch526 bytes
twfahey’s picture

twfahey commented
Issue summary: View changes
geek-merlin’s picture

geek-merlin
Primary language German
Location Freiburg, Germany
commented
Status: Active » Fixed

Thanks for fixing this! Committed.

  • axel.rutz committed af68664 on 8.x-1.x authored by twfahey 
    Issue #2952892 by twfahey: Can't save values for line height

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.