PollRecentBlock dependency injection

Look like the wrong patch?

You don't need to add multiple test runs, only when that really makes sense, like it is something that is different for sqlite/postgresql or different drupal core versions.

1. +++ b/src/Plugin/Block/PollRecentBlock.php
   @@ -44,9 +51,36 @@ class PollRecentBlock extends BlockBase {
   +
   +  /**
   +   * {@inheritdoc}
   +   */
   +  public static function create(ContainerInterface $container, array $configuration, $plugin_id, $plugin_definition) {
   +    return new static(
   +      $configuration,
   +      $plugin_id,
   +      $plugin_definition,
   +      $container->get('entity_type.manager')
   +    );
   +  }
   

   The create and construct method should be above all other methods and usually __construct() is first.

2. +++ b/src/Plugin/Block/PollRecentBlock.php
   @@ -44,9 +51,36 @@ class PollRecentBlock extends BlockBase {
   +   * @param array $configuration
   +   * @param string $plugin_id
   +   * @param mixed $plugin_definition
   +   * @param \Drupal\Core\Entity\EntityTypeManagerInterface $entity_type_manager
   +   */
   

   those need descriptions, start with what the parent has.

Tested the latest patch and it applies cleanly.

+++ b/src/Plugin/Block/PollRecentBlock.php
@@ -15,7 +18,45 @@ use Drupal\Core\Session\AccountInterface;
+
+  /** @var \Drupal\Core\Entity\EntityTypeManagerInterface  */
+  private $entityTypeManager;
+
+  /**
+   * Overrides \Drupal\Component\Plugin\PluginBase::__construct().
+   *
+   * Overrides the construction of context aware plugins to allow for
+   * unvalidated constructor based injection of contexts.
+   *

Do not use private properties, use protected.

The docblock of the property is not following coding standards.

Also, the description on the construct method is too much. Everyone knows how constructor injection works, just say "Construct a new X object" or something like that.

Updated the patch from @myLies and fixed the issues that @Berdir has found.

Committed.