Problem/Motivation

It would be nice to be able to make multiple queries from the xero query service injecting it once or be able to instantiate multiple objects to do so.

Proposed resolution

Maybe a fake factory service?

Remaining tasks

Do it.

API changes

Probably the service is going to have a factory definition. This shouldn't necessarily change the usage of Xero query.

CommentFileSizeAuthor
#7 xero-2491150-add-xero-query-factory-7.patch8.69 KBmradcliffe
#7 2941150-interdiff-4-7.txt2.02 KBmradcliffe
#4 2941150-interdiff-2-4.patch2.79 KBmradcliffe
#4 xero-2941150-add-xero-query-factory-4.patch9.47 KBmradcliffe
#2 xero-2941150-add-xero-query-factory-2.patch6.68 KBmradcliffe

Comments

mradcliffe created an issue. See original summary.

mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented
Status: Active » Needs review
StatusFileSize
new xero-2941150-add-xero-query-factory-2.patch6.68 KB

Status: Needs review » Needs work

The last submitted patch, 2: xero-2941150-add-xero-query-factory-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new xero-2941150-add-xero-query-factory-4.patch9.47 KB
new 2941150-interdiff-2-4.patch2.79 KB

Well, shucks... I forgot about that ComplexDataInterface change that I was subscribed to in core.

Fixing unit tests~

The last submitted patch, 4: xero-2941150-add-xero-query-factory-4.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Status: Needs review » Needs work

The last submitted patch, 4: 2941150-interdiff-2-4.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new 2941150-interdiff-4-7.txt2.02 KB
new xero-2491150-add-xero-query-factory-7.patch8.69 KB

Fixes some test-related issues found with PHP 7.1 as well.

  • mradcliffe committed 0a775cf on 8.x-1.x 
    Issue #2941150 by mradcliffe: Adds a xero.query factory for multi-...
mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented
Status: Needs review » Fixed

Fixed in 0a775cf and tagged a beta release for 1.1 compatible with Drupal > 8.5.x

  • mradcliffe committed e93a9a4 on 8.x-1.x 
    Issue #2941150 by mradcliffe: Changes xero.query.factory to be a...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.