1. configure = admin/config/development/content_type_settings

There is no use of this in Info file, so can we remove it?

2. Can we remove blank space after below lines:

'access arguments' => array('custom content type dashboard'),
'access callback' => 'user_access',
'file' => 'inc/content_dashboard.inc',

3. $form['quick_filter']['Value'] = array(
contentdashboard.inc (Value is added in caps, it should be value)

4. All the private function name should start with module name
eg._get_data function name should be _content_dashboard_get_data

Comments

sandeepscs created an issue. See original summary.

sandeepscs’s picture

Issue summary: View changes
sandeepscs’s picture

Issue summary: View changes
swati.nuna’s picture

Assigned: Unassigned » swati.nuna

  • a485fc2 committed on 7.x-1.x
    Issue #2938033 by sandeepscs, swati.nuna: Review comment
    
swati.nuna’s picture

Assigned: swati.nuna » Unassigned
Status: Active » Fixed

Fixed.

sandeepscs’s picture

Status: Fixed » Closed (fixed)
sandeepscs’s picture

Title: Review comment » Review comment 2