This module has a good README, but there are the following issues that need to be fixed in order to ensure it is of better quality and standard:

- SOCIAL AUTH LINKEDIN MODULE
This line should be removed

- CREATE LINKEDIN APPLICATION
This section should be renamed to INSTALLATION

- We need to add a MAINTAINERS section.

CommentFileSizeAuthor
#24 2934735-final.patch543 bytesyogesh01
#19 interdiff-2934735-15-17.patch464 bytesTanvish Jha
#19 2934735-17.patch3.6 KBTanvish Jha
#17 interdiff-2934735-14-15.txt2.19 KBTanvish Jha
#17 2934735-15.patch3.67 KBTanvish Jha
#14 interdiff-2934735-12-14.txt892 bytesTanvish Jha
#14 2934735-14.patch1.97 KBTanvish Jha
#12 interdiff-2934735-6-12.patch955 bytesTanvish Jha
#12 2934735-12.patch1.15 KBTanvish Jha
#10 interdiff-2934735-1-9.txt0 bytesTanvish Jha
#9 2934735-9.patch1017 bytesTanvish Jha
#8 2934735-6.patch335 bytesTanvish Jha
#6 2934735-6.patch335 bytesTanvish Jha
#4 2934735-4.patch2.01 KBTanvish Jha
#2 2934735-1.patch594 bytesTanvish Jha

Comments

Kifah Meeran created an issue. See original summary.

Tanvish Jha’s picture

Tanvish Jha commented
Component: Code » Documentation
Status: Active » Needs review
StatusFileSize
new 2934735-1.patch594 bytes

There is already a maintainers section but I added one more maintainer. Added the first change. The second change is not applicable.

MaskyS’s picture

MaskyS commented
Status: Needs review » Needs work

Link needs updating. Second change not applicable?

Tanvish Jha’s picture

Tanvish Jha commented
Status: Needs work » Needs review
StatusFileSize
new 2934735-4.patch2.01 KB
Tanvish Jha’s picture

Tanvish Jha commented

Interdiff cannot be created because the earlier patch had some issues. The latest one provided in #4 should work.

Tanvish Jha’s picture

Tanvish Jha commented
StatusFileSize
new 2934735-6.patch335 bytes
Tanvish Jha’s picture

Tanvish Jha commented
Tanvish Jha’s picture

Tanvish Jha commented
StatusFileSize
new 2934735-6.patch335 bytes

I had cloned the 1.x version of this module. The second case if for that version as well. The second issue stated is already fixed in the 2.x version.

Tanvish Jha’s picture

Tanvish Jha commented
StatusFileSize
new 2934735-9.patch1017 bytes
Tanvish Jha’s picture

Tanvish Jha commented
StatusFileSize
new interdiff-2934735-1-9.txt0 bytes
MaskyS’s picture

MaskyS commented
Status: Needs review » Needs work

Good work. I'd like to add the following:

When posting a support request, please inform what does the status report say
at admin/reports/composer-manager and if you were able to see any errors in
Recent log entries.

This link needs to be replaced with admin/reports/dblog

   * Download Linkedin Base Library for TheLeague OAuth2 PHP library
   (https://github.com/thephpleague/oauth2-linkedin). We recommend to use
   Composer Manager module to install the library.

All references to Composer Manager (some not listed here) need to be removed. Also, let's make these instructions look like in Social Auth Google.

* Recommended modules should be removed from the table of contents, as well as the Recommended modules section.

Tanvish Jha’s picture

Tanvish Jha commented
Status: Needs work » Needs review
StatusFileSize
new 2934735-12.patch1.15 KB
new interdiff-2934735-6-12.patch955 bytes

Fixed them upppp.

MaskyS’s picture

MaskyS commented
Status: Needs review » Needs work

Um, the link was not replaced?

Tanvish Jha’s picture

Tanvish Jha commented
Status: Needs work » Needs review
StatusFileSize
new 2934735-14.patch1.97 KB
new interdiff-2934735-12-14.txt892 bytes

I had it updated in the readme but I guess I must not have saved it while creating the patch.

MaskyS’s picture

MaskyS commented 
  1. +++ b/README.txt
@@ -77,20 +64,11 @@ SUPPORT REQUESTS
-https://www.drupal.org/node/2841076

    This is the part that should have been replaced with https://www.drupal.org/social_auth_linkedin/issues 

  2. +++ b/README.txt
@@ -77,20 +64,11 @@ SUPPORT REQUESTS
-at admin/reports/composer-manager and if you were able to see any errors in

    and this link should be admin/reports/dblog

MaskyS’s picture

MaskyS commented
Status: Needs review » Needs work
Tanvish Jha’s picture

Tanvish Jha commented
Status: Needs work » Needs review
StatusFileSize
new 2934735-15.patch3.67 KB
new interdiff-2934735-14-15.txt2.19 KB
MaskyS’s picture

MaskyS commented
Status: Needs review » Needs work 
+++ b/README.txt
@@ -60,15 +48,15 @@ CONFIGURATION
+to /user/login/linkedIn, so theming and customizing the button or link

this linkedin link shouldn't be linkedIn ;p

Other than that this looks perfect now.

Tanvish Jha’s picture

Tanvish Jha commented
Status: Needs work » Needs review
StatusFileSize
new 2934735-17.patch3.6 KB
new interdiff-2934735-15-17.patch464 bytes
MaskyS’s picture

MaskyS commented
Status: Needs review » Reviewed & tested by the community

Great! Let's wait for @gvso now.

  • gvso committed 8ce03ad on 8.x-2.x authored by Tanvish Jha 
    Issue #2934735 by Tanvish Jha, Kifah Meeran: Update the README for...
gvso’s picture

gvso
Primary language Spanish
commented
Status: Reviewed & tested by the community » Fixed 
+++ b/README.txt
@@ -1,20 +1,18 @@
+Social Auth LinkedIn Module is a LinkedIn Authentication integration for Drupal.

I make this similar to Social Auth Google:

Social Auth LinkedIn is a LinkedIn authentication integration for Drupal. It is
based on the Social Auth and Social API projects

It adds to the site:
 * A new url: /user/login/linkedin.
 * A settings form on /admin/config/social-api/social-auth/linkedin page.
 * A LinkedIn logo in the Social Auth Login block.
yogesh01’s picture

yogesh01 commented
Assigned: Unassigned » yogesh01
Status: Fixed » Needs work

The link to the issue queue is incorrect.

yogesh01’s picture

yogesh01 commented
Status: Needs work » Needs review
StatusFileSize
new 2934735-final.patch543 bytes

added the correct issue queue link.

MaskyS’s picture

MaskyS commented
Status: Needs review » Reviewed & tested by the community

Thanks @yogesh01. We should be good now.

The last submitted patch, 2: 2934735-1.patch, failed testing. View results

The last submitted patch, 9: 2934735-9.patch, failed testing. View results

The last submitted patch, 12: 2934735-12.patch, failed testing. View results

The last submitted patch, 12: interdiff-2934735-6-12.patch, failed testing. View results

The last submitted patch, 14: 2934735-14.patch, failed testing. View results

The last submitted patch, 19: 2934735-17.patch, failed testing. View results

The last submitted patch, 17: 2934735-15.patch, failed testing. View results

The last submitted patch, 19: interdiff-2934735-15-17.patch, failed testing. View results

  • gvso committed 14cb642 on 8.x-2.x 
    Issue #2934735 by yogesh01, Kifah Meeran: Update the README for Social...
gvso’s picture

gvso
Primary language Spanish
commented
Status: Reviewed & tested by the community » Fixed

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.