After updating to 8.4.4 heading fields return status report warning.

TOKENS OR TOKEN TYPES MISSING NAME PROPERTY

$info['tokens']['paragraph-field_heading']['size']
$info['tokens']['paragraph-field_heading']['text']

In my case the heading fields are used on a paragraph type.

CommentFileSizeAuthor
#14 Screen Shot 2018-08-15 at 3.14.03 PM.png65.18 KBjnycz
#10 token-or-token-name-missing-2934662-10.patch1.33 KBzero2one
#8 heading.module.patch1.31 KBsdmeyers

Comments

jnycz created an issue. See original summary.

jnycz’s picture

jnycz commented
Issue summary: View changes
zero2one’s picture

zero2one commented

I added the missing heading field token information.

See commit on 8.x-1.x branch

zero2one’s picture

zero2one commented
Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

seirerman’s picture

seirerman commented

The patch only works if I use the same name for my heading field.

Can you reopen this issue?

zero2one’s picture

zero2one commented
Status: Closed (fixed) » Needs work
sdmeyers’s picture

sdmeyers commented
StatusFileSize
new heading.module.patch1.31 KB

Here's a patch that seems to solve the issue no matter what machine name you have for your field. At least it works for me... enjoy.

jnycz’s picture

jnycz commented

Patch from #8 fixed the issue. Not seeing any problems now, thanks @sdmeyers!

zero2one’s picture

zero2one commented
Status: Needs work » Needs review
StatusFileSize
new token-or-token-name-missing-2934662-10.patch1.33 KB

Thank you for the fix.

I refactored the patch of so it has less nesting.

  • zero2one committed c1fd379 on 8.x-1.x 
    Issue #2934662 by zero2one, sdmeyers: TOKENS OR TOKEN TYPES MISSING NAME...
zero2one’s picture

zero2one commented
Status: Needs review » Fixed

Fix is merged.

zero2one’s picture

zero2one commented
Status: Fixed » Closed (fixed)
jnycz’s picture

jnycz commented
StatusFileSize
new Screen Shot 2018-08-15 at 3.14.03 PM.png65.18 KB

After updating the module to 8.x-1.1 and removing sdmeyers patch the warning appears again.

zero2one’s picture

zero2one commented
Status: Closed (fixed) » Needs work

Thank you for the catch (paragraphs !== paragraph).

Code is fixed in the new 8.x-1.2 release.
I added also token support when the heading field is used in other entity types then paragraphs.

See release notes.

zero2one’s picture

zero2one commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

mpark’s picture

mpark commented

Hello, I have to reopen it, cause still the warning can see it. Everything updated (12/02/2018).