The login form results in a fatal error even if TFA is not enabled in two cases
1) The plugin the module is trying to look for does not exist.
2) The plugin value is an empty string which happens in case of reset as the settings don't exist.

Proposed resolution

  • Stop further processing if TFA is not enabled and continue the normal login flow thereby not trying to instantiate a plugin which might not exist.
  • An empty check on the plugin name to prevent the module from trying to instantiate a plugin with id as an empty string.
CommentFileSizeAuthor
#2 2930385-fatal-error-tfa-not-enabled-2.patch1.45 KBtherealssj

Comments

therealssj created an issue. See original summary.

therealssj’s picture

therealssj commented
StatusFileSize
new 2930385-fatal-error-tfa-not-enabled-2.patch1.45 KB
nerdstein’s picture

nerdstein
he/him
Primary language English
Location United States
commented

Code review looks great and Daggerhart is doing a smoke test now

daggerhart’s picture

daggerhart commented
Status: Active » Reviewed & tested by the community

This applies, works and fixes another issue I was struggling with. RTBC!

  • nerdstein committed 292e3fa on 8.x-1.x authored by therealssj 
    Issue #2930385 by therealssj: Fatal error in login form even if TFA not...
nerdstein’s picture

nerdstein
he/him
Primary language English
Location United States
commented
Status: Reviewed & tested by the community » Fixed

Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.