Closed (fixed)
Project:
Modifiers Pack
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
2 Dec 2017 at 20:14 UTC
Updated:
15 Jan 2018 at 16:29 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
attisanComment #3
kybermanHi, which composer package are you using? Could you please provide how are you adding that package? Did you try our instructions inside modifiers_bg_parallax/README.md? Thank you.
Comment #4
attisancomposer package is "drupal-composer/drupal-project"
we decided to go for the git version:
however, the provided patch makes sense either way, as the parallax project is named "pixelcog/parallax.js" officially. Thus it would be wise to stick to that wording - other than renaming the library as proposed in the README.md. If you wish, I could provide the patch including the updated README.md (replacing the lines using "pixelcog/parallax-js" with "pixelcog/parallax.js")
hth,
attisan
Comment #5
kybermanThanks for that @attisan, I agree. I'll update location of "parallax.js" and also "videojs-Background" (including the readme).
Comment #7
kybermanIt seems that videojs-background is correct package name, so only parallax.js is commited. Thank you.