As I'm using composer to checkout the parallax.js git repository I stumbled upon this.

hth

Comments

attisan created an issue. See original summary.

attisan’s picture

kyberman’s picture

Version: 8.x-1.0-alpha2 » 8.x-1.x-dev

Hi, which composer package are you using? Could you please provide how are you adding that package? Did you try our instructions inside modifiers_bg_parallax/README.md? Thank you.

attisan’s picture

composer package is "drupal-composer/drupal-project"

we decided to go for the git version:

        {
            "type": "package",
            "package": {
                "name": "pixelcog/parallax.js",
                "version": "dev-*",
                "type": "drupal-library",
                "source": {
                    "url": "https://github.com/pixelcog/parallax.js",
                    "type": "git",
                    "reference": "origin/master"
                }
            }
        },

however, the provided patch makes sense either way, as the parallax project is named "pixelcog/parallax.js" officially. Thus it would be wise to stick to that wording - other than renaming the library as proposed in the README.md. If you wish, I could provide the patch including the updated README.md (replacing the lines using "pixelcog/parallax-js" with "pixelcog/parallax.js")

hth,
attisan

kyberman’s picture

Assigned: Unassigned » kyberman

Thanks for that @attisan, I agree. I'll update location of "parallax.js" and also "videojs-Background" (including the readme).

  • kyberman committed d997d91 on 8.x-1.x
    Issue #2928051 by attisan, kyberman: Rename library folder to parallax....
kyberman’s picture

Assigned: kyberman » Unassigned
Status: Active » Fixed

It seems that videojs-background is correct package name, so only parallax.js is commited. Thank you.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.