When trying to retrieve files without extensions, following error message occurs:

Notice: Undefined index: extension in Drupal\stage_file_proxy\FetchManager->writeFile() (line 151 of modules\contrib\stage_file_proxy\src\FetchManager.php).

Made a patch to fix this.

CommentFileSizeAuthor
#14 2926771-14.patch591 bytessourabhjain
#5 stage_file_proxy-D7-fix-extension-notice-2926771-5.patch591 bytestobiasb
#2 stage_file_proxy-D7-fix-extension-notice-2926771-2.patch586 bytesfirewaller
fix-extension-notice.patch607 bytesiamweird

Issue fork stage_file_proxy-2926771

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

iamweird created an issue. See original summary.

firewaller’s picture

firewaller commented
StatusFileSize
new stage_file_proxy-D7-fix-extension-notice-2926771-2.patch586 bytes

This issue also happens in Drupal 7. Patch attached.

geek-merlin’s picture

geek-merlin
Primary language German
Location Freiburg, Germany
commented
Status: Active » Reviewed & tested by the community

We can bikeshed if this can be done more elegant, but code is trivial and totally makes sense.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: stage_file_proxy-D7-fix-extension-notice-2926771-2.patch, failed testing. View results

tobiasb’s picture

tobiasb
Primary language German
Location Berlin
commented
Status: Needs work » Needs review
StatusFileSize
new stage_file_proxy-D7-fix-extension-notice-2926771-5.patch591 bytes

Patch for D7 can not apply in the format.

Status: Needs review » Needs work

The last submitted patch, 5: stage_file_proxy-D7-fix-extension-notice-2926771-5.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

tobiasb’s picture

tobiasb
Primary language German
Location Berlin
commented
Status: Needs work » Needs review
Issue tags: -extension, -file extension
greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

The issue is for d8 but the d8 patch doesn't apply. The d7 patch should wait until d8 is fixed, ideally.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Seems like an simple innocent check. Can reroll the 8.x patch as needed.

smustgrave opened merge request !18

  • smustgrave committed 1fafa9c on 8.x-1.x 
    Issue #2926771: PHP notice when destination file doesn't have an...
smustgrave’s picture

smustgrave commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

sourabhjain’s picture

sourabhjain
Primary language English
commented
StatusFileSize
new 2926771-14.patch591 bytes

This issue is still exist on Drupal 7.x-1.10 version. Creating patch for that.