Support from Acquia helps fund testing for Drupal Acquia logo

Comments

joseph.olstad created an issue. See original summary.

joseph.olstad’s picture

Patch:
https://www.drupal.org/files/issues/323110_52_remove_open_basedir_requir...

credit to:

git commit -m 'Issue #2926150 by nenne, gpk, BarisW, MrHaroldA, webflo: Remove the open_basedir requirement check'

joseph.olstad’s picture

Status: Reviewed & tested by the community » Needs review
joseph.olstad’s picture

Issue summary: View changes
joseph.olstad’s picture

not sure if the patch is working yet or not

joseph.olstad’s picture

Status: Needs review » Reviewed & tested by the community

I tested the above patch, it works.

David_Rothstein’s picture

Status: Reviewed & tested by the community » Postponed

This can probably go in, but the Drupal 8 issue needs to get fixed first - postponing it on that.

MustangGB’s picture

Priority: Normal » Major
Issue tags: -Drupal 7.60 target

Removing tag until D8 fix goes in, instead bumping priority so it doesn't get forgotten.

MustangGB’s picture

Priority: Major » Normal
Issue tags: +Drupal 7.70 target

On second thoughts, this probably makes more sense.

joseph.olstad’s picture

Status: Postponed » Reviewed & tested by the community
Issue tags: -Drupal 7.70 target +Drupal 7.68 target

This just was pushed into 8.8.x , the 8.x issue is 'fixed'

Setting this issue to RTBC, ready to go it in !

joseph.olstad’s picture

joseph.olstad’s picture

This change was made in D8.

Patch:
https://www.drupal.org/files/issues/323110_52_remove_open_basedir_requir...

credit to:

git commit -m 'Issue #2926150 by nenne, gpk, BarisW, MrHaroldA, webflo: Remove the open_basedir requirement check'

MustangGB’s picture

Issue tags: -Drupal 7.68 target +Drupal 7.69 target
MustangGB’s picture

Issue tags: -Drupal 7.69 target +Drupal 7.70 target
poker10’s picture

Issue tags: -Drupal 7.70 target

Adding a patch from the parent issue (#323110-53: Remove the open_basedir requirement check ) here so we can run tests properly.

I have tested it manually and simpletest still works when this check is removed and open_basedir is enabled.

mcdruid’s picture

Issue tags: +RTBM

Just to spell out the tl;dr of the rather long and meandering parent issue:

PHP's open_basedir used to cause problems with simpletest's usage of curl, so a requirements check was added pointing out the conflict with the testing framework.

In #1671200: Simpletest broken: CURLOPT_COOKIEJAR cannot be NULL (and maybe others) the conflicts with open_basedir were resolved.

So the requirements check is no longer required, and in fact could be harmful as it recommends disabling a security feature unnecessarily.

The patch looks good, thanks!

  • poker10 committed b03b613 on 7.x
    Issue #2926150 by MrHaroldA, BarisW: D7 Remove the open_basedir...

poker10 credited BarisW.

poker10 credited MrHaroldA.

poker10’s picture

Status: Reviewed & tested by the community » Fixed
Issue tags: -RTBM

Thanks everyone!

Added credits from the parent issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.