Problem/Motivation

When there are no overrides, media_youtube_file_formatter_video_view() takes video dimensions from global defaults, ignoring default video dimensions provided by oEmbed code.

Proposed resolution

  1. Store default video dimensions in file metadata
  2. Use per-file default video dimension instead of global defaults when viewing a video

    3. https://www.drupal.org/project/media_youtube/issues/2932942

Remaining tasks

https://www.drupal.org/project/media_youtube/issues/2932942
Submit a patch

User interface changes

Video dimensions match defaults provided by YouTube

API changes

No API changes

Data model changes

No data model changes

CommentFileSizeAuthor
#2 2921208.patch1.63 KBvalthebald

Comments

valthebald created an issue. See original summary.

valthebald’s picture

valthebald
Location Sofia
commented
Status: Active » Needs review
StatusFileSize
new 2921208.patch1.63 KB
valthebald’s picture

valthebald
Location Sofia
commented
Issue summary: View changes

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Status: Needs review » Fixed

Looks great, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Issue summary: View changes
Status: Closed (fixed) » Needs work
Related issues: +#2932942: 7.x-3.6 regression. Youtube iframe lost width configuration

this commit caused a regression, reverting it and cutting a new release without this commit.

here is the reported regression:
https://www.drupal.org/project/media_youtube/issues/2932942

  • joseph.olstad committed 58b4ec9 on 7.x-3.x 
    Issue #2921208 by valthebald, joseph.olstad: Populate metadata coming...