I access the "metatag" UI, but it prints an error message to me.
I screenshot the error message, then upload the picture below.
It is similar with cancel_button does not work with ldap_servers

CommentFileSizeAuthor
#10 cancel_button-entity-routes-bug-FIXED-2920480-9.patch9.31 KBdanmuzyka
#10 cancel_button-entity-routes-bug-FAILING-TEST-2920480-9.patch7.4 KBdanmuzyka
#8 cancel_button-entity-routes-bug-FIXED-2920480-8.patch9.25 KBdanmuzyka
#7 cancel_button-entity-routes-bug-FAILING-TEST-2920480-5.patch7.34 KBdanmuzyka
#5 cancel_button-entity-routes-bug-FAILING-TEST-2920480-5.patch7.34 KBdanmuzyka
aqVra23.png73.4 KBa65162

Comments

a65162 created an issue. See original summary.

a65162’s picture

a65162 commented
Issue summary: View changes
a65162’s picture

a65162 commented
Issue summary: View changes
norman.lol’s picture

norman.lol
he/him
Primary language German
Location Berlin
commented
Priority: Normal » Major
danmuzyka’s picture

danmuzyka commented
StatusFileSize
new cancel_button-entity-routes-bug-FAILING-TEST-2920480-5.patch7.34 KB

Attaching a patch that adds a test to demonstrate the failing condition of link templates in the entity annotation that do not have valid routes.

danmuzyka’s picture

danmuzyka commented
Status: Active » Needs review

Changing status to "Needs Review."

danmuzyka’s picture

danmuzyka commented
Assigned: Unassigned » danmuzyka
StatusFileSize
new cancel_button-entity-routes-bug-FAILING-TEST-2920480-5.patch7.34 KB
danmuzyka’s picture

danmuzyka commented
StatusFileSize
new cancel_button-entity-routes-bug-FIXED-2920480-8.patch9.25 KB

Attaching a patch that fixes the issue (includes both the test from the previous patch, and the code fix).

The last submitted patch, 7: cancel_button-entity-routes-bug-FAILING-TEST-2920480-5.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

danmuzyka’s picture

danmuzyka commented
StatusFileSize
new cancel_button-entity-routes-bug-FAILING-TEST-2920480-9.patch7.4 KB
new cancel_button-entity-routes-bug-FIXED-2920480-9.patch9.31 KB

Adding versions of the patches that address some code style issues.

The last submitted patch, 10: cancel_button-entity-routes-bug-FAILING-TEST-2920480-9.patch, failed testing. View results

daniel.kushner’s picture

daniel.kushner commented
Status: Needs review » Reviewed & tested by the community

Looks Good!

danmuzyka’s picture

danmuzyka commented
Title: This module causes "Metatag" module can't work correctly. » Error when using with entities defined using link templates that refer to missing routes

  • danmuzyka authored 36bdba4 on 8.x-1.x 
    Issue #2920480 by danmuzyka, a65162, dkushner731: Error when using with...
danmuzyka’s picture

danmuzyka commented
Status: Reviewed & tested by the community » Fixed

Merged into 8.x-1.x.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.