The settings form for specifying whether editors/ reviewers can make a transition in a workflow is using the wrong variable name for the default value. Attaching screenshot of the setting in question.

CommentFileSizeAuthor
#7 2918302-07-TEST-ONLY.patch1.05 KBjhedstrom
#6 interdiff.txt1.05 KBsukanya.ramakrishnan
#6 2918302-wrong-default-value-workflow-participants-form-06.patch2.18 KBsukanya.ramakrishnan
#4 interdiff.txt1.05 KBsukanya.ramakrishnan
#4 2918302-wrong-default-value-workflow-participants-form-04.patch2.18 KBsukanya.ramakrishnan
#2 2918302-wrong-default-value-workflow-participants-form-02.patch1.13 KBsukanya.ramakrishnan
Screen Shot 2017-10-23 at 7.34.17 PM.png45.33 KBsukanya.ramakrishnan

Comments

sukanya.ramakrishnan created an issue. See original summary.

sukanya.ramakrishnan’s picture

sukanya.ramakrishnan commented
Status: Active » Needs review
StatusFileSize
new 2918302-wrong-default-value-workflow-participants-form-02.patch1.13 KB

Submitting patch for the reported issue.

sukanya.ramakrishnan’s picture

sukanya.ramakrishnan commented
Title: Default value for allowing participants to make a transition in a workflow on the settings form is wrong » Workflow participants settings form on a transition in a workflow has wrong default value
sukanya.ramakrishnan’s picture

sukanya.ramakrishnan commented
StatusFileSize
new 2918302-wrong-default-value-workflow-participants-form-04.patch2.18 KB
new interdiff.txt1.05 KB

Adding a test for this feature.

sukanya.ramakrishnan’s picture

sukanya.ramakrishnan commented
sukanya.ramakrishnan’s picture

sukanya.ramakrishnan commented
StatusFileSize
new 2918302-wrong-default-value-workflow-participants-form-06.patch2.18 KB
new interdiff.txt1.05 KB

Submitting new patch with test for this feature and corrected comment.

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented
StatusFileSize
new 2918302-07-TEST-ONLY.patch1.05 KB

Adding the test only patch to verify the fix.

Status: Needs review » Needs work

The last submitted patch, 7: 2918302-07-TEST-ONLY.patch, failed testing. View results

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented
Status: Needs work » Reviewed & tested by the community

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented
Status: Reviewed & tested by the community » Fixed

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.