We recently encountered an issue where the Juicer embed javascript was conflicting with the version of Slick we are using on the site. After emailing Juicer.io about it, they pointed us to use //assets.juicer.io/embed-no-jquery-no-slick.js. Proposing that an option be added to the module to allow site builders to select which javascript file to include.

CommentFileSizeAuthor
#2 juicerio-js-embed-option-2917520-2.patch2.09 KBjojonaloha

Comments

jojonaloha created an issue. See original summary.

jojonaloha’s picture

jojonaloha commented
Status: Active » Needs review
StatusFileSize
new juicerio-js-embed-option-2917520-2.patch2.09 KB

Attached patch adds the proposed option and includes the 3 options: the default one juicer shows when you copy the code from their website, the no-jquery one that the module currently uses (also remains the default if this variable is not set) and the new one for no-jquery-no-slick.

laughnan’s picture

laughnan
he/him/his
commented

Looks good to me. Let me test it locally @jojonaloha and I'll get it merged into the 7.x branch.

laughnan’s picture

laughnan
he/him/his
commented
Status: Needs review » Reviewed & tested by the community

This patch worked successfully on my local 7x site.

  • laughnan committed cff2c7a on 7.x-1.x authored by jojonaloha 
    Issue #2917520 by jojonaloha: Allow Using Alternative Juicer Javascript...
laughnan’s picture

laughnan
he/him/his
commented
Status: Reviewed & tested by the community » Fixed
laughnan’s picture

laughnan
he/him/his
commented

Created a related issue for the 8.x branch to support alternative JS libraries: #2917855: Alternative JS Embeds for Drupal 8 Block Plugin

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.