Problem/Motivation

When a user is added to an entity as a workflow participant, it would be really great if they were notified of this.

Proposed resolution

Send notifications when they are added.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#5 2916869-05.patch26.21 KBjhedstrom
#5 interdiff-2916869-02-05.txt3.82 KBjhedstrom
#2 2916869-02.patch24.68 KBjhedstrom

Comments

jhedstrom created an issue. See original summary.

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented
Status: Active » Needs review
StatusFileSize
new 2916869-02.patch24.68 KB

Status: Needs review » Needs work

The last submitted patch, 2: 2916869-02.patch, failed testing. View results

kevin.dutra’s picture

kevin.dutra commented

I've done a pass at reviewing the code. Overall the code and tests look good to me, there's just the matter of a little cleanup to get the existing tests passing.

  1. +++ b/tests/src/Kernel/ParticipantNotifierTest.php
@@ -0,0 +1,145 @@
+  public static $modules = ['filter', 'token'];

    Also, the EntityDeleteTest appears to need the filter module. 

  2. +++ b/tests/src/Kernel/ParticipantNotifierTest.php
@@ -0,0 +1,145 @@
+    $this->installConfig(['filter', 'system']);

    Based on the test failures, it looks like both the NotificationsTest and EntityDeleteTest require the filter module's configs to be installed so that the plain text format is available.

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-2916869-02-05.txt3.82 KB
new 2916869-05.patch26.21 KB

While fixing the test failures, I realized that the new setting enable_notifcations had no effect at all. This resolves that and should fix the tests.

  • jhedstrom committed 0aae525 on 8.x-2.x 
    Issue #2916869 by jhedstrom, kevin.dutra: Send notifications when users...
jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.