The uc_payflowpro_charge hook was incorrectly calling the uc_cart_complete_order function to create the user for use in the return array. I am guessing this was correct at some point in time but Ubercart has since changed how this should work, therefore I modified the hook using the uc_authorizenet module as an example. This fixes several issues including no order number showing up on the Order Complete page, anonymous users not being logged in after order complete as specified in the Ubercart configuration settings, order numbers being incremented by two, and possibly other side effects I didn't notice. This patch also includes other fixes and code style corrections.

Cheers,

Jon Antoine
www.antoinesolutions.com

CommentFileSizeAuthor
uc_payflowpro.patch7.21 KBjantoine

Comments

johnalbin’s picture

johnalbin
they/他
Primary language English
Location Taipei, Taiwan
commented
Status: Needs review » Reviewed & tested by the community

We're using this patch on a production site. Thanks, Antoine!

kwinters’s picture

kwinters commented
Status: Reviewed & tested by the community » Fixed

I left some of the spacing in string concatenation the way it was, because of http://drupal.org/coding-standards - everything else is committed as provided in the patch for D5.

In the D6 version, the main bug in this issue (uc_cart_complete_order call) was already fixed, so the only net changes were putting the response into globals and the style changes.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.